Skip to content

feat: staking v5 migrations #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weichweich merged 10 commits into from
Sep 15, 2021
Merged

feat: staking v5 migrations #249

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e89d937
wip: initialize v5 migrations
weichweich Sep 7, 2021
9c97a70
fix: try-runtime
weichweich Sep 7, 2021
deee4c0
wip: staking migrations
weichweich Sep 7, 2021
4848664
tests: add tests
weichweich Sep 8, 2021
d77927b
fix tests
weichweich Sep 13, 2021
e75f792
chore: 🧹
weichweich Sep 13, 2021
f0d7131
add benchmarks
Sep 14, 2021
8e27436
fix weights
weichweich Sep 14, 2021
617152b
Merge branch 'develop' into aw-staking-migrations
weichweich Sep 14, 2021
760d813
Merge remote-tracking branch 'origin/develop' into aw-staking-migrations
weichweich Sep 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions pallets/delegation/src/migrations.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ impl<T: Config> VersionMigratorTrait<T> for DelegationStorageVersion {
fn pre_migrate(&self) -> Result<(), &str> {
match *self {
Self::V1 => v1::pre_migrate::<T>(),
Self::V2 => Err("Already latest v2 version."),
Self::V2 => Ok(()),
}
}

Expand All @@ -76,7 +76,7 @@ impl<T: Config> VersionMigratorTrait<T> for DelegationStorageVersion {
fn post_migrate(&self) -> Result<(), &str> {
match *self {
Self::V1 => v1::post_migrate::<T>(),
Self::V2 => Err("Migration from v2 should have never happened in the first place."),
Self::V2 => Ok(()),
}
}
}
Expand Down Expand Up @@ -104,11 +104,6 @@ impl<T: Config> DelegationStorageMigrator<T> {
/// latest possible.
#[cfg(feature = "try-runtime")]
pub(crate) fn pre_migrate() -> Result<(), &'static str> {
ensure!(
StorageVersion::<T>::get() < DelegationStorageVersion::latest(),
"Already the latest storage version."
);

// Don't need to check for any other pre_migrate, as in try-runtime it is also
// called in the migrate() function. Same applies for post_migrate checks for
// each version migrator.
Expand Down
9 changes: 2 additions & 7 deletions pallets/did/src/migrations.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ impl<T: Config> VersionMigratorTrait<T> for DidStorageVersion {
fn pre_migrate(&self) -> Result<(), &str> {
match *self {
Self::V1 => v1::pre_migrate::<T>(),
Self::V2 => Err("Already latest v2 version."),
Self::V2 => Ok(()),
}
}

Expand All @@ -76,7 +76,7 @@ impl<T: Config> VersionMigratorTrait<T> for DidStorageVersion {
fn post_migrate(&self) -> Result<(), &str> {
match *self {
Self::V1 => v1::post_migrate::<T>(),
Self::V2 => Err("Migration from v2 should have never happened in the first place."),
Self::V2 => Ok(()),
}
}
}
Expand Down Expand Up @@ -104,11 +104,6 @@ impl<T: Config> DidStorageMigrator<T> {
/// latest possible.
#[cfg(feature = "try-runtime")]
pub(crate) fn pre_migrate() -> Result<(), &'static str> {
ensure!(
StorageVersion::<T>::get() < DidStorageVersion::latest(),
"Already the latest storage version."
);

// Don't need to check for any other pre_migrate, as in try-runtime it is also
// called in the migrate() function. Same applies for post_migrate checks for
// each version migrator.
Expand Down
Loading