Skip to content

Conversation

@wischli
Copy link
Contributor

@wischli wischli commented Jul 13, 2022

fixes KILTProtocol/ticket#2087

  • Upgrades to latest Polkadot v0.9.25
  • Removes Launch Pallet removal migration
  • No migrations required since we don't use Parity DB

Noteworthy PRs from Substrate that influenced changes:

Checklist:

  • I have verified that the code works
    • No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@wischli wischli requested review from ntn-x2, trusch and weichweich July 13, 2022 09:47
Copy link
Contributor

@ntn-x2 ntn-x2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@trusch
Copy link
Contributor

trusch commented Jul 14, 2022

I think paritytech/substrate#11431 is worth mentioning. It enables the storage transaction support for all extrinsics if I understand it right, so we don't have to take care of strictly first checking everything and then writing to storage.

@wischli wischli merged commit d8af5d1 into develop Jul 14, 2022
@wischli wischli deleted the wf/polkadot-v0.9.25 branch July 14, 2022 13:39
wischli added a commit that referenced this pull request Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants