Skip to content

Conversation

@wischli
Copy link
Contributor

@wischli wischli commented Jul 21, 2022

fixes KILTProtocol/ticket#2101

Noteworthy mentions

Checklist:

  • I have verified that the code works
    • No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
  • I have verified that the code is easy to understand
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@wischli wischli requested review from ntn-x2 and weichweich July 21, 2022 05:34
}

impl pallet_transaction_payment::Config for Runtime {
type Event = Event;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting to note: For standalone we do a lazy assignment of the TransactionPayment module:

TransactionPayment: pallet_transaction_payment = 7,

For the parachain runtimes we don't. That's why we did not have to add the Event<T> type as was done for Spiritnet and Peregrine.

Copy link
Contributor

@ntn-x2 ntn-x2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@weichweich weichweich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wischli wischli enabled auto-merge (squash) July 28, 2022 10:04
@wischli wischli merged commit bbacd91 into develop Jul 28, 2022
@wischli wischli deleted the wf/2101-polkadot-v0.9.26 branch July 28, 2022 13:10
wischli added a commit that referenced this pull request Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants