Skip to content

fix: changes to public credentials based on feedback #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntn-x2 merged 21 commits into from
Aug 8, 2022
Merged

fix: changes to public credentials based on feedback #392

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
54b5842
wip: changing stuff based on meeting
ntn-x2 Aug 1, 2022
649e04a
feat: generate credential ID on chain
ntn-x2 Aug 1, 2022
8c932fc
remove dependency on attestation pallet
ntn-x2 Aug 2, 2022
974a16e
add revocation and unrevocation
ntn-x2 Aug 2, 2022
eb25d72
add checks that the attestation pallet also performs
ntn-x2 Aug 2, 2022
6f5439d
add ctype info in the storage
ntn-x2 Aug 2, 2022
dc1de22
Add support for access control
ntn-x2 Aug 3, 2022
4348f4b
Update benchmarks
ntn-x2 Aug 3, 2022
ddf7994
Runtimes compiling
ntn-x2 Aug 3, 2022
f63875c
nodes compiling with new filtering feature
ntn-x2 Aug 3, 2022
adf053a
Remove authorization id from possible filters
ntn-x2 Aug 3, 2022
4e9ae3e
fmt
ntn-x2 Aug 3, 2022
de14b05
update benchmarks and default weights (to be re-executed on bench mac…
ntn-x2 Aug 3, 2022
eed9c4d
change serialization logic for ctype filter
ntn-x2 Aug 3, 2022
72600a8
fixes and chores
ntn-x2 Aug 3, 2022
886f4e8
refactor common function
ntn-x2 Aug 3, 2022
3def3d6
change get_credential to only take a credential ID parameter
ntn-x2 Aug 4, 2022
798e4fb
rename rpc endpoints for easier decoration
ntn-x2 Aug 4, 2022
c24a947
update RPC method names again
ntn-x2 Aug 4, 2022
971ce6c
change encoding of filter to be camelCase to be consistent with Polka…
ntn-x2 Aug 4, 2022
e95d50e
Apply suggestions from review
ntn-x2 Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update RPC method names again
  • Loading branch information
@ntn-x2
ntn-x2 committed Aug 4, 2022
commit c24a9470ee247b774cb21ed133bbf57713b302e1
4 changes: 2 additions & 2 deletions rpc/public-credentials/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ pub trait PublicCredentialsFilter<Credential> {
#[rpc(client, server)]
pub trait PublicCredentialsApi<BlockHash, OuterSubjectId, OuterCredentialId, OuterCredentialEntry, CredentialFilter> {
/// Return a credential that matches the provided credential ID, if found.
#[method(name = "credentials_get_credential")]
#[method(name = "credentials_getCredential")]
fn get_credential(
&self,
credential_id: OuterCredentialId,
Expand All @@ -50,7 +50,7 @@ pub trait PublicCredentialsApi<BlockHash, OuterSubjectId, OuterCredentialId, Out
/// Return all the credentials issued to the provided subject, optionally
/// filtering with the provided logic. The result is a vector of (credential
/// identifier, credential entry).
#[method(name = "credentials_get_credentials")]
#[method(name = "credentials_getCredentials")]
fn get_credentials(
&self,
subject: OuterSubjectId,
Expand Down