Skip to content

Conversation

@wischli
Copy link
Contributor

@wischli wischli commented Sep 6, 2022

fixes KILTProtocol/ticket#2173

Working branch against Substrate/Polkadot/Cumulus master upstream with goal:

  • Converts 1d weight (u64) to 2d struct
pub struct Weight {
	/// The computational time used to execute some logic based on reference hardware.
	ref_time: u64,
	/// The size of the proof needed to execute some logic.
	proof_size: u64,
}

Checklist:

  • I have verified that the code works
    • No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@weichweich weichweich added the 🛑 dont-merge DONT MERGE label Sep 9, 2022
@weichweich weichweich changed the title [DO NOT MERGE] feat: add weights v2 feat: add weights v2 Sep 9, 2022
@wischli wischli mentioned this pull request Sep 21, 2022
6 tasks
@wischli
Copy link
Contributor Author

wischli commented Oct 7, 2022

Closing due to merging the current changes in #416

@wischli wischli closed this Oct 7, 2022
@weichweich weichweich deleted the wf-2173-add-weights-v2 branch January 10, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants