Skip to content

Conversation

@wischli
Copy link
Contributor

@wischli wischli commented Sep 16, 2022

  • Normalizes all runtime APIs (DID, Staking, Public Credentials) by moving them into separate crates within the runtime-api directory of root

wischli and others added 29 commits July 20, 2022 14:30
* tests: 80%

* feat: rm delegate_another_candidate and more

* docs: remove deprecated weight

* Apply suggestions from code review

Co-authored-by: Antonio <[email protected]>

Co-authored-by: Antonio <[email protected]>
@wischli wischli requested a review from ntn-x2 September 16, 2022 14:32
@wischli wischli added this to the 1.9.0 milestone Oct 5, 2022
@wischli wischli requested a review from ntn-x2 October 31, 2022 14:36
@wischli
Copy link
Contributor Author

wischli commented Oct 31, 2022

@ntn-x2 Albi wants me to merge all staking refactor PR into a single one. Since you already reviewed #384, could you quickly go over this PR before I merge it and present to Albi?

Copy link
Contributor

@ntn-x2 ntn-x2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor nitpick, but otherwise LGMT! 🎉

Base automatically changed from wf/1930-staking-refactor to develop November 3, 2022 07:18
@wischli wischli requested a review from weichweich November 3, 2022 07:50

// If you feel like getting in touch with us, you can do so at [email protected]

//! Primitives used by the Parachains Tick, Trick and Track.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :D

@wischli wischli merged commit 1b8ff25 into develop Nov 3, 2022
@wischli wischli deleted the wf-1930-staking-refactor-api branch November 3, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants