Skip to content

feat: cleanup duplicate dependencies #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wischli merged 3 commits into from
Oct 20, 2022
Merged

feat: cleanup duplicate dependencies #419

wischli merged 3 commits into from
Oct 20, 2022

Conversation

@wischli
Copy link
Contributor

@wischli wischli commented Oct 7, 2022

fixes KILTProtocol/ticket#2225

  • Removes duplicate dependencies by applying cargo machete
  • NOTE: cargo machete --fix removed more deps than necessary, e.g. scale-info and codec and did not apply removed deps to features

Checklist:

  • I have verified that the code works
    • No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@weichweich weichweich requested review from ntn-x2 and weichweich and removed request for weichweich October 17, 2022 09:30
ntn-x2
ntn-x2 approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@ntn-x2 ntn-x2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✈️✈️✈️

weichweich
weichweich approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@weichweich weichweich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ntn-x2 ntn-x2 mentioned this pull request Oct 20, 2022
Merged
@wischli wischli enabled auto-merge (squash) October 20, 2022 13:47
@wischli wischli merged commit b84929a into develop Oct 20, 2022
@wischli wischli deleted the wf-2225-apply-cargo-machete branch October 20, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ntn-x2 ntn-x2 ntn-x2 approved these changes

@weichweich weichweich weichweich approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wischli @ntn-x2 @weichweich