Skip to content

feat: add meaningful errors #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntn-x2 merged 12 commits into from
Oct 31, 2023
Merged

feat: add meaningful errors #572

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3fe3fae
Fmt
ntn-x2 Oct 18, 2023
4736f82
Add proper errors for runtime-common DIP-related stuff
ntn-x2 Oct 18, 2023
1eb68a2
Add proper error to provider runtime API
ntn-x2 Oct 18, 2023
4e201aa
wip: return String for errors
ntn-x2 Oct 18, 2023
229f828
Minor refinements
ntn-x2 Oct 19, 2023
8de5223
Minor fixes
ntn-x2 Oct 19, 2023
8ea6b11
Refactor dip-provider to use u16 error codes
ntn-x2 Oct 19, 2023
07c97ab
Transform errors into u16s
ntn-x2 Oct 19, 2023
a6fe54e
Add correct bit shifting logic
ntn-x2 Oct 19, 2023
d49c42d
Better enum
ntn-x2 Oct 19, 2023
9cf4bfd
Cleanup
ntn-x2 Oct 20, 2023
88c3b2d
Better error handling and reporting
ntn-x2 Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add correct bit shifting logic
  • Loading branch information
@ntn-x2
ntn-x2 committed Oct 19, 2023
commit a6fe54e0d9a10ed41ec4745b4613138e93919afa
14 changes: 7 additions & 7 deletions crates/kilt-dip-support/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,13 +129,13 @@ where
error.into().to_be().into()
}
DipSiblingProviderStateProofVerifierError::IdentityCommitmentMerkleProofVerificationError(error) => {
u16::from(error.into().to_be()) | (1 << 8)
u16::from(error.into().to_be()) | (0b1 << 15)
}
DipSiblingProviderStateProofVerifierError::DipProofVerificationError(error) => {
u16::from(error.into().to_be()) | (2 << 8)
u16::from(error.into().to_be()) | (0b11 << 14)
}
DipSiblingProviderStateProofVerifierError::DidSignatureVerificationError(error) => {
u16::from(error.into().to_be()) | (3 << 8)
u16::from(error.into().to_be()) | (0b111 << 13)
}
}
}
Expand Down Expand Up @@ -391,16 +391,16 @@ where
DipChildProviderStateProofVerifierError::InvalidBlockHeight => 0,
DipChildProviderStateProofVerifierError::InvalidBlockHash => 1,
DipChildProviderStateProofVerifierError::ParachainHeadMerkleProofVerificationError(error) => {
u16::from(error.into().to_be()) | (1 << 8)
u16::from(error.into().to_be()) | (0b1 << 15)
}
DipChildProviderStateProofVerifierError::IdentityCommitmentMerkleProofVerificationError(error) => {
u16::from(error.into().to_be()) | (2 << 8)
u16::from(error.into().to_be()) | (0b11 << 14)
}
DipChildProviderStateProofVerifierError::DipProofVerificationError(error) => {
u16::from(error.into().to_be()) | (3 << 8)
u16::from(error.into().to_be()) | (0b111 << 13)
}
DipChildProviderStateProofVerifierError::DidSignatureVerificationError(error) => {
u16::from(error.into().to_be()) | (4 << 8)
u16::from(error.into().to_be()) | (0b1111 << 12)
}
}
}
Expand Down