Skip to content

Conversation

@rflechtner
Copy link
Contributor

@rflechtner rflechtner commented Mar 5, 2025

fixes https://github.com/KILTprotocol/ticket/issues/3798

Increases consumers limits to 100 for peregrine, spiritnet, mocks & tests.
Configs for dip-templates are left as-is.

It's hard for me to tell if this is going to have an impact on benchmarking / transaction weights though, how can we check this?

Checklist:

  • I have verified that the code works
    • No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)
    • Either PR or Ticket to update the Docs
    • Link the PR/Ticket here

Configs for dip-templates are left as-is.
@rflechtner rflechtner marked this pull request as ready for review March 5, 2025 14:30
@rflechtner rflechtner requested a review from ntn-x2 March 5, 2025 14:30
Copy link
Contributor

@ntn-x2 ntn-x2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it has any impact on benchmarks and weights.

@rflechtner rflechtner merged commit 7e481bb into bonded-coins-audit-fixes Mar 6, 2025
14 of 15 checks passed
@rflechtner rflechtner deleted the audit-issue-3 branch March 6, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants