Skip to content

feat: add new potential type definitions #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ntn-x2 merged 5 commits into from
Oct 18, 2022
Merged

feat: add new potential type definitions #662

ntn-x2 merged 5 commits into from
Oct 18, 2022

Conversation

@ntn-x2
Copy link
Contributor

@ntn-x2 ntn-x2 commented Oct 14, 2022 •
edited
Loading

Add runtime definitions as implemented in KILTprotocol/kilt-node#423.

Checklist

  • Apply any changes if the node PR is updated
  • Generate new TS type definitions to reflect the new runtime APIs (on develop)

@ntn-x2 ntn-x2 self-assigned this Oct 14, 2022
@ntn-x2 ntn-x2 added the ✋on hold status: on hold label Oct 14, 2022
@ntn-x2 ntn-x2 mentioned this pull request Oct 14, 2022
Merged
Base automatically changed from ta-remove-queryWeb3Name to develop October 14, 2022 11:48
@ntn-x2 ntn-x2 force-pushed the aa/new-runtime-api-types branch 2 times, most recently from 7a88ba2 to 044ee8c Compare October 17, 2022 09:34
@ntn-x2 ntn-x2 changed the title [DO NOT MERGE] feat: add new potential type definitions feat: add new potential type definitions Oct 17, 2022
@ntn-x2 ntn-x2 marked this pull request as ready for review October 17, 2022 09:54
@ntn-x2 ntn-x2 requested a review from rflechtner October 17, 2022 09:56
rflechtner
rflechtner approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@rflechtner rflechtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, that looks real good!

@ntn-x2
Copy link
Contributor Author

ntn-x2 commented Oct 17, 2022

@rflechtner I will wait for the 1.8.0 latest image to be pushed, to verify that it still works with that. We could then release with this PR in as the new runtime calls are not exposed via the SDK API, but only internally in the resolver and in the integration tests. What do you think?

@ntn-x2 ntn-x2 force-pushed the aa/new-runtime-api-types branch from 044ee8c to 418c5fa Compare October 18, 2022 09:03
@ntn-x2 ntn-x2 removed the ✋on hold status: on hold label Oct 18, 2022
@ntn-x2 ntn-x2 merged commit f1d1126 into develop Oct 18, 2022
@ntn-x2 ntn-x2 deleted the aa/new-runtime-api-types branch October 18, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rflechtner rflechtner rflechtner approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ntn-x2 ntn-x2

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ntn-x2 @rflechtner