feat: add new type definitions for public credential RPC endpoints #33
Conversation
|
a general point on this: I think we need to investigate how we imagine the link between this and the sdk's new type augmentation package, which generates types from these definitions. Almost feels to me like the two should be integrated into one. |
|
Albi had an open PR in the SDK to integrate these types in there: KILTprotocol/sdk-js#522 |
|
Not sure what the best way ahead would be. It will probably become clearer once we start integrating it into the SDK. At least this PR would provide the basic content that can then be put anywhere it's needed. |
|
@rflechtner also, I think we have to do this if we want the new RPC methods to be properly displayed in polkadot apps. If we don't do that, then only the SDK knows how to use those endpoints. |
ntn-x2
force-pushed
the
aa/public-credentials-types
branch
from
ed8521e to
8ceabbf
Compare
rflechtner
left a comment
rflechtner
left a comment
There was a problem hiding this comment.
LGTM! As far as I can see there simply is no versioning mechanism for rpcs, is there?
* feat: add did rpc decorations * chore: cleanup old types and update spec version * Revert "chore: cleanup old types and update spec version" This reverts commit fa994c6. * fix typos * Add runtime calls definitions * Fix types and add runtime API definitions * update @polkadot/types dependency * improve description of state_calls * add public credentials definition (#33) * Update RPC descriptions * Fix type for attester in PublicCredentialFilter * feat: add definitions for DID RPC * remove support for public credentials from * Add trailing new line * chore: remove support for Ethereum account linking * chore: adjust runtime version to match new types * Update @PolkaDot dependencies to 0.9.3 to support new AccountId33 type * Replace Text with AccountId3{2,3} for DidVerificationKey type * Rename RPC types to avoid type conflict issues * Change encryption key type to also be base58-encoded Co-authored-by: Antonio Antonino <[email protected]>
This PR is based on top of #32 (so please merge that one first).
It adds type definitions and RPC decorations for the new public credentials RPC endpoints as defined in KILTprotocol/kilt-node#378 and KILTprotocol/kilt-node#392.