Skip to content

Conversation

jplotts
Copy link
Contributor

@jplotts jplotts commented May 27, 2025

The SQL statements don't contain an ORDER BY clause, so the ordering can't be an intentional check for this exercise. This exercise happens to work most of the time because BigQuery tends to return results in the same order, but sometimes it doesn't. Learn users shouldn't have to deal with this non-determinism in the check.

http://b/415948668

The SQL statements don't contain an `ORDER BY` clause, so the ordering
can't be an intentional check for this exercise. This exercise happens
to work most of the time because BigQuery tends to return results in the
same order, but sometimes it doesn't. Learn users shouldn't have to deal
with this non-determinism in the check.

http://b/415948668
@jplotts jplotts requested a review from djherbis May 27, 2025 14:29
Copy link
Contributor

@djherbis djherbis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great catch!

@jplotts jplotts merged commit 003526b into master May 27, 2025
4 checks passed
@jplotts jplotts deleted the fix-ordering-sql-ex branch May 27, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants