Skip to content

Rename integration_tests to smoke#118

Closed
yiyoulin678 wants to merge 16 commits into
Khabib73:mainfrom
yiyoulin678:rename-integration-tests
Closed

Rename integration_tests to smoke#118
yiyoulin678 wants to merge 16 commits into
Khabib73:mainfrom
yiyoulin678:rename-integration-tests

Conversation

@yiyoulin678

Copy link
Copy Markdown
Contributor

Fixes #104

Renamed integration_tests to smoke across the project, including:

  • test directories
  • CI workflows
  • Makefile targets
  • imports and references

@Khabib73

Khabib73 commented May 24, 2026

Copy link
Copy Markdown
Owner

@yiyoulin678 This branch has conflicts that must be resolved, you should also delete the file copilot-instructions.md

@Khabib73 Khabib73 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use it: poetry run

Comment thread .github/workflows/ci.yaml Outdated
@Khabib73

Copy link
Copy Markdown
Owner

Looks like I should fix it. I'll be back coming soon @yiyoulin678

@Khabib73 Khabib73 marked this pull request as draft May 24, 2026 15:29
@Khabib73 Khabib73 marked this pull request as ready for review May 24, 2026 18:16
@Khabib73

Khabib73 commented May 25, 2026

Copy link
Copy Markdown
Owner

Hi @yiyoulin678, I'm ready to merge your PR, but can you improve your commits descriptions using commit conventions? Please read this CONVENTIONS. For example: instead Rename integration_tests to smoke use test: rename integration_tests to smoke etc

Comment thread Makefile
poetry run yatl ./integration_tests
.PHONY: smoke
smoke:
poetry run python -m src.yatl.run

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct way to running poetry run yatl ./smoke

@yiyoulin678 yiyoulin678 force-pushed the rename-integration-tests branch from 64e4912 to cc8fdac Compare May 26, 2026 05:35
@yiyoulin678

Copy link
Copy Markdown
Contributor Author

@Khabib73 I have resolved the conflicts and updated the commit messages according to the conventions.

@yiyoulin678 yiyoulin678 closed this by deleting the head repository May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename integration_tests to smoke

2 participants