MSL: SPIR-V assembly fixes #2062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible to pass unsigned integers to `OpSMulExtended`. In that case, we want to do a signed multiply with sign extension, so make sure the operands are forced to be interpreted as signed. This was an oversight on my part when I added these instructions. Fixes the CTS test `dEQP-VK.spirv_assembly.instruction.compute.signed_op.uint_smulextended`.
Fixes the CTS test `dEQP-VK.spirv_assembly.instruction.compute.opundef.undefined_constant_composite` and helps with another, `dEQP-VK.spirv_assembly.instruction.compute.opundef.undefined_spec_constant_composite`. Unfortunately, fixing the latter requires another change.
Undef values may be of struct type and may be used in constants. Therefore, they must be interleaved with constants and types. Fixes the rest of the Vulkan CTS test `dEQP-VK.spirv_assembly.instruction.compute.opundef.undefined_spec_constant_composite`. (Please excuse the churn in the reference output; it's an inevitable result of this change.)
Fixes two more CTS tests under `dEQP-VK.spirv_assembly.instruction.compute.empty_struct.copying`.
cdavis5e
force-pushed
the
msl-spirv-assembly-fixes
branch
from
8fee2a1 to
061cdd2
Compare
8 tasks
CaseyHillers
pushed a commit
to CaseyHillers/engine
that referenced
this pull request
Nov 22, 2022
* This call has been deprecated in the upstream dep * KhronosGroup/SPIRV-Cross#2062
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this pull request
Nov 22, 2022
* This call has been deprecated in the upstream dep * KhronosGroup/SPIRV-Cross#2062
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are miscellaneous fixes for various issues that for some reason are all grouped together under
shaderSPIRVAssemblyConformance.Fixes five CTS tests.
Closes #2058.