Skip to content

Conversation

@smjoshiatglobus
Copy link
Contributor

I got entangled in Git mess! Here are the same changes, as one squashed commit:

Main changes:

Other changes, mostly for development support:

  • Added references to known issue X tags of VR == 'DA' not getting deleted #56 in tests code
  • Added Pipfile for optional development setup using pipenv
  • Added configuration for spell-checking using cspell and added custom dictionary.
  • Fixed a typo (only one!)
  • Formatted code in tests and example folders using black
  • Suppressed some warnings from Sourcery

smjoshiatglobus and others added 3 commits January 12, 2024 09:01
merge from head repo.
Fix for unit test failing is in #64
@smjoshiatglobus smjoshiatglobus changed the title Squashed commits from PR 64 Fixes for SQ type and unit tests, squashed from PR 64 Feb 29, 2024
@pchoisel
Copy link
Collaborator

LGTM
Thanks for taking the time !
The PR is marked as draft, but can I merge it ?

@smjoshiatglobus smjoshiatglobus marked this pull request as ready for review March 13, 2024 16:49
@smjoshiatglobus
Copy link
Contributor Author

LGTM Thanks for taking the time ! The PR is marked as draft, but can I merge it ?

Yes! I have marked it ready now. It is a regular pull request now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants