Restrict the API surface with internal and final tags #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those methods still need to consider BC impact for now until the next major version, but this will reduce the public API surface in the future.
stof
commented
Jun 13, 2025
| use Twig\Extension\RuntimeExtensionInterface; | ||
|
|
||
| /** | ||
| * @final since 3.8.0 |
Collaborator
Author
There was a problem hiding this comment.
The MenuRuntimeExtension itself cannot become @internal as its instantiation has to be a public API to be usable by projects registering the runtime into Twig (KnpMenuBundle in the common case, but that's still a separate package), but all the methods can be @internal as they are only meant to be referenced by the MenuExtension as implementation of the (public) Twig callables.
garak
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those methods still need to consider BC impact for now until the next major version, but this will reduce the public API surface in the future.