-
Notifications
You must be signed in to change notification settings - Fork 191
fix wording (mostly in docs) #411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes grammatical and wording issues throughout the documentation and code comments.
- Corrects grammatical errors in docstrings and documentation files
- Fixes verb conjugation and article usage inconsistencies
- Improves clarity and readability of written content
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Knp/Menu/Renderer/RendererProviderInterface.php | Fixes verb form in exception docstring |
| src/Knp/Menu/Provider/MenuProviderInterface.php | Fixes verb form in exception docstring |
| doc/examples/01_apply_active_class_to_whole_tree.md | Corrects article usage and grammar in header and content |
| doc/05-Matcher.md | Improves sentence structure and word choice |
| doc/04-Iterators.md | Adds clarifying article for better readability |
| doc/01-Basic-Menus.md | Fixes multiple grammatical errors including verb forms and articles |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| Let's face it, creating menus sucks. Menus - a common aspect of any | ||
| site - can range from being simple and mundane to giant monsters that | ||
| become a headache to code and maintain. | ||
| becomes a headache to code and maintain. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is wrong. giant monsters is a plural, and so is Menus. I don't see which subject could be singular here to justify becomes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does the "see more" says ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It only displays a contextual menu where I can accept or dismiss the suggestion and flag it as incorrect.
Anyway, it seems wrong in this case. I'll propose a fix PR

No description provided.