Skip to content

Conversation

@garak
Copy link
Collaborator

@garak garak commented Sep 2, 2025

No description provided.

@garak garak requested a review from Copilot September 2, 2025 07:13
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes grammatical and wording issues throughout the documentation and code comments.

  • Corrects grammatical errors in docstrings and documentation files
  • Fixes verb conjugation and article usage inconsistencies
  • Improves clarity and readability of written content

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Knp/Menu/Renderer/RendererProviderInterface.php Fixes verb form in exception docstring
src/Knp/Menu/Provider/MenuProviderInterface.php Fixes verb form in exception docstring
doc/examples/01_apply_active_class_to_whole_tree.md Corrects article usage and grammar in header and content
doc/05-Matcher.md Improves sentence structure and word choice
doc/04-Iterators.md Adds clarifying article for better readability
doc/01-Basic-Menus.md Fixes multiple grammatical errors including verb forms and articles

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@garak garak merged commit 72f8b64 into KnpLabs:master Sep 22, 2025
11 checks passed
@garak garak deleted the fix-docs branch September 22, 2025 07:20
Let's face it, creating menus sucks. Menus - a common aspect of any
site - can range from being simple and mundane to giant monsters that
become a headache to code and maintain.
becomes a headache to code and maintain.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is wrong. giant monsters is a plural, and so is Menus. I don't see which subject could be singular here to justify becomes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not being a native English speaker, I put my trust in Grammarly
Schermata del 2025-09-23 11-23-03

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does the "see more" says ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It only displays a contextual menu where I can accept or dismiss the suggestion and flag it as incorrect.
Anyway, it seems wrong in this case. I'll propose a fix PR

@garak garak mentioned this pull request Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants