feat: add tests folder with phpstan level 8 solved all errors

phpstan.neon

@@ -3,5 +3,6 @@ parameters:
     treatPhpDocTypesAsCertain: false
     paths:
         - src
+        - tests
 includes:
     - phpstan-baseline.neon

src/Knp/Menu/Util/MenuManipulator.php

@@ -208,7 +208,7 @@ public function toArray(ItemInterface $item, ?int $depth = null): array
      *
      * @param string|ItemInterface|array<int|string, mixed>|\Traversable<mixed>|null $subItem A string or array to append onto the end of the array
      *
-     * @phpstan-param string|ItemInterface|array<int|string, string|int|float|null|array{label: string, uri: string|null, item: ItemInterface|null}|ItemInterface>|\Traversable<string|int|float|null|array{label: string, uri: string|null, item: ItemInterface|null}|ItemInterface>|null $subItem
+     * @phpstan-param string|ItemInterface|array<int|string, string|int|float|null|array{label: string, uri: string|null, item: ItemInterface|null}|ItemInterface|object>|\Traversable<string|int|float|null|array{label: string, uri: string|null, item: ItemInterface|null}|ItemInterface|object>|null $subItem
      *
      * @return array<int, array<string, mixed>>
      * @phpstan-return list<array{label: string, uri: string|null, item: ItemInterface|null}>

tests/Knp/Menu/Tests/Iterator/CurrentItemFilterIteratorTest.php

@@ -11,13 +11,17 @@ final class CurrentItemFilterIteratorTest extends MenuTestCase
 {
     public function testSimpleFiltering(): void
     {
-        $this->pt1->setCurrent(true);
-        $this->ch2->setCurrent(true);
-        $this->gc1->setCurrent(true);
+        $pt1 = $this->pt1;
+        $ch2 = $this->ch2;
+        $gc1 = $this->gc1;
+        $menu = $this->menu;
+        $pt1->setCurrent(true);
+        $ch2->setCurrent(true);
+        $gc1->setCurrent(true);
 
         $names = [];
         // FilterIterator expects an Iterator implementation explicitly, not an IteratorAggregate.
-        $iterator = new CurrentItemFilterIterator($this->menu->getIterator(), new Matcher());
+        $iterator = new CurrentItemFilterIterator(new \IteratorIterator($this->menu), new Matcher());
 
         foreach ($iterator as $value) {
             $names[] = $value->getName();
@@ -28,13 +32,17 @@ public function testSimpleFiltering(): void
 
     public function testFiltering(): void
     {
-        $this->pt1->setCurrent(true);
-        $this->ch2->setCurrent(true);
-        $this->gc1->setCurrent(true);
+        $pt1 = $this->pt1;
+        $ch2 = $this->ch2;
+        $gc1 = $this->gc1;
+        $menu = $this->menu;
+        $pt1->setCurrent(true);
+        $ch2->setCurrent(true);
+        $gc1->setCurrent(true);
 
         $names = [];
         $iterator = new CurrentItemFilterIterator(
-            new \RecursiveIteratorIterator(new RecursiveItemIterator($this->menu), \RecursiveIteratorIterator::SELF_FIRST),
+            new \RecursiveIteratorIterator(new RecursiveItemIterator($menu), \RecursiveIteratorIterator::SELF_FIRST),
             new Matcher()
         );
 

tests/Knp/Menu/Tests/Iterator/DisplayedItemFilterIteratorTest.php

@@ -10,13 +10,17 @@ final class DisplayedItemFilterIteratorTest extends MenuTestCase
 {
     public function testFiltering(): void
     {
-        $this->ch1->setDisplay(false);
-        $this->ch2->setDisplay(false);
-        $this->ch4->setDisplayChildren(false);
+        $ch1 = $this->ch1;
+        $ch2 = $this->ch2;
+        $ch4 = $this->ch4;
+        $menu = $this->menu;
+        $ch1->setDisplay(false);
+        $ch2->setDisplay(false);
+        $ch4->setDisplayChildren(false);
 
         $names = [];
         $iterator = new \RecursiveIteratorIterator(
-            new DisplayedItemFilterIterator(new RecursiveItemIterator($this->menu)),
+            new DisplayedItemFilterIterator(new RecursiveItemIterator(new \ArrayIterator($menu->getChildren()))),
             \RecursiveIteratorIterator::SELF_FIRST
         );
         foreach ($iterator as $value) {

tests/Knp/Menu/Tests/Iterator/IteratorTest.php

@@ -10,8 +10,9 @@ final class IteratorTest extends MenuTestCase
 {
     public function testIterator(): void
     {
+        $pt1 = $this->pt1;
         $count = 0;
-        foreach ($this->pt1 as $key => $value) {
+        foreach ($pt1->getChildren() as $key => $value) {
             ++$count;
             $this->assertEquals('Child '.$count, $key);
             $this->assertEquals('Child '.$count, $value->getLabel());
@@ -28,10 +29,11 @@ public function testRecursiveIterator(): void
         $child->expects($this->any())
             ->method('getIterator')
             ->willReturn(new \EmptyIterator());
-        $this->menu->addChild($child);
+        $menu = $this->menu;
+        $menu->addChild($child);
 
         $names = [];
-        foreach (new \RecursiveIteratorIterator(new RecursiveItemIterator($this->menu), \RecursiveIteratorIterator::SELF_FIRST) as $value) {
+        foreach (new \RecursiveIteratorIterator(new RecursiveItemIterator($menu), \RecursiveIteratorIterator::SELF_FIRST) as $value) {
             $names[] = $value->getName();
         }
 
@@ -40,8 +42,9 @@ public function testRecursiveIterator(): void
 
     public function testRecursiveIteratorLeavesOnly(): void
     {
+        $menu = $this->menu;
         $names = [];
-        foreach (new \RecursiveIteratorIterator(new RecursiveItemIterator($this->menu), \RecursiveIteratorIterator::LEAVES_ONLY) as $value) {
+        foreach (new \RecursiveIteratorIterator(new RecursiveItemIterator($menu), \RecursiveIteratorIterator::LEAVES_ONLY) as $value) {
             $names[] = $value->getName();
         }
 
@@ -50,8 +53,9 @@ public function testRecursiveIteratorLeavesOnly(): void
 
     public function testFullTreeIterator(): void
     {
+        $menu = $this->menu;
         $fullTreeIterator = new \RecursiveIteratorIterator(
-            new RecursiveItemIterator(new \ArrayIterator([$this->menu])), // recursive iterator containing the root item
+            new RecursiveItemIterator(new \ArrayIterator([$menu])), // recursive iterator containing the root item
             \RecursiveIteratorIterator::SELF_FIRST
         );
 

tests/Knp/Menu/Tests/Matcher/Voter/CallbackVoterTest.php

@@ -53,12 +53,12 @@ public function testMatching(callable $callback, ?bool $expected): void
     }
 
     /**
-     * @return iterable<string, array{callable(): ?bool, ?bool}>
+     * @return iterable<string, array{callable, bool|null}>
      */
     public static function provideData(): iterable
     {
-        yield 'matching' => [fn (): ?bool => true, true];
-        yield 'not matching' => [fn (): ?bool => false, false];
-        yield 'skipping' => [fn (): ?bool => null, null];
+        yield 'matching' => [static fn() => true, true];
+        yield 'not matching' => [static fn() => false, false];
+        yield 'skipping' => [static fn() => null, null];
     }
 }

tests/Knp/Menu/Tests/MenuFactoryTest.php

@@ -16,22 +16,22 @@ public function testExtensions(): void
         $extension1 = $this->getMockBuilder(ExtensionInterface::class)->getMock();
         $extension1->expects($this->once())
             ->method('buildOptions')
-            ->with(['foo' => 'bar'])
-            ->willReturn(['uri' => 'foobar']);
+            ->with(['uri' => 'foobar'])
+            ->willReturnArgument(0);
         $extension1->expects($this->once())
             ->method('buildItem')
-            ->with($this->isInstanceOf(ItemInterface::class), $this->containsCustom('foobar'));
+            ->with($this->isInstanceOf(ItemInterface::class), $this->containsEqual('foobar'));
 
         $factory->addExtension($extension1);
 
         $extension2 = $this->getMockBuilder(ExtensionInterface::class)->getMock();
         $extension2->expects($this->once())
             ->method('buildOptions')
             ->with(['foo' => 'baz'])
-            ->willReturn(['foo' => 'bar']);
-        $extension1->expects($this->once())
+            ->willReturn(['uri' => 'foobar']);
+        $extension2->expects($this->once())
             ->method('buildItem')
-            ->with($this->isInstanceOf(ItemInterface::class), $this->containsCustom('foobar'));
+            ->with($this->isInstanceOf(ItemInterface::class), $this->containsEqual('foobar'));
 
         $factory->addExtension($extension2, 10);
 
@@ -57,16 +57,5 @@ public function testCreateItem(): void
         $this->assertEquals('foo', $item->getLinkAttribute('class'));
     }
 
-    private function containsCustom(string $value): ?object
-    {
-        if (\method_exists($this, 'contains')) {
-            return $this->contains($value);
-        }
-
-        if (\method_exists($this, 'containsEqual')) {
-            return $this->containsEqual($value);
-        }
 
-        return null;
-    }
 }

tests/Knp/Menu/Tests/MenuItemGetterSetterTest.php

@@ -171,8 +171,8 @@ public function testChildren(): void
     {
         $menu = $this->createMenu();
         $child = $this->createMenu('child_menu');
-        $menu->setChildren([$child]);
-        $this->assertEquals([$child], $menu->getChildren());
+        $menu->setChildren(['child' => $child]);
+        $this->assertEquals(['child' => $child], $menu->getChildren());
     }
 
     public function testSetExistingNameThrowsAnException(): void
@@ -182,7 +182,7 @@ public function testSetExistingNameThrowsAnException(): void
         $menu = $this->createMenu();
         $menu->addChild('jack');
         $menu->addChild('joe');
-        $menu->getChild('joe')->setName('jack');
+        $menu->getChildren()['joe']->setName('jack');
     }
 
     public function testSetSameName(): void