Skip to content

Fixed code search api deprecation of sort and order parameters #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fixed code search api deprecation of sort and order parameters #1112

wants to merge 1 commit into from

Conversation

yoonper
Copy link
Contributor

@yoonper yoonper commented Apr 14, 2023

acrobat
acrobat requested changes May 13, 2023
View reviewed changes
Copy link
Collaborator

@acrobat acrobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoonper thanks for the PR!

The changes in method parameters is BC break. You should deprecate the params not required anymore or deprecate the old code method and introduce a new method for this new api.

@yoonper yoonper closed this by deleting the head repository Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acrobat acrobat acrobat requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoonper @acrobat