Skip to content

Add tests for the count function #1530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add tests for the count function #1530

wants to merge 1 commit into from

Conversation

@Allex-Nik
Copy link
Collaborator

@Allex-Nik Allex-Nik commented Oct 29, 2025 •
edited
Loading

Fixes #1496

Allex-Nik
Allex-Nik commented Nov 6, 2025
View reviewed changes
core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/api/count.kt

class CountTests {

// Test data
Copy link
Collaborator Author

@Allex-Nik Allex-Nik Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These fields with test data are reinitialized for each test method, which creates some overhead (some fields are not used by some methods). But I think it should not be significant, it is still safe, and it saves from a lot of duplication. Is it reasonable to leave it as it is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zaleslaw zaleslaw Awaiting requested review from zaleslaw

@Jolanrensen Jolanrensen Awaiting requested review from Jolanrensen

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add unit tests for count function

3 participants

@Allex-Nik @Jolanrensen