Upgraded dependencies #70
Conversation
Moved Android to v33 Moved iOS to v14.0 Moved app code from UIKit to fully SwiftUI
There was a problem hiding this comment.
I think we should use default hierarchy now
There was a problem hiding this comment.
Default hierarchy? Can you give me a resource I can look at to duplicate?
There was a problem hiding this comment.
|
If we want to update the build setup to the latest recommendation, then we need to use a library catalog |
I am going to create an issue, and address in a separate PR. I feel it's valuable we get these fixes out ASAP so folks can use the sample. |
shared/build.gradle.kts
Outdated
| val iosX64Main by getting | ||
| val iosArm64Main by getting | ||
| val iosSimulatorArm64Main by getting |
There was a problem hiding this comment.
Do you mean iosX64Main -> iosSimulatorArm64Main can be removed?
shared/build.gradle.kts
Outdated
| val iosMain by getting | ||
| val iosX64Test by getting | ||
| val iosArm64Test by getting | ||
| val iosSimulatorArm64Test by getting | ||
| val iosTest by creating { | ||
| dependsOn(commonTest) | ||
| iosX64Test.dependsOn(this) | ||
| iosArm64Test.dependsOn(this) | ||
| iosSimulatorArm64Test.dependsOn(this) | ||
| } | ||
| val iosTest by getting |
There was a problem hiding this comment.
we may remove all unused code here and above
There was a problem hiding this comment.
Do you mean iosX64Test -> iosSimulatorArm64Test?
shared/build.gradle.kts
Outdated
| val iosMain by getting | ||
| val iosX64Test by getting | ||
| val iosArm64Test by getting | ||
| val iosSimulatorArm64Test by getting | ||
| val iosTest by creating { | ||
| dependsOn(commonTest) | ||
| iosX64Test.dependsOn(this) | ||
| iosArm64Test.dependsOn(this) | ||
| iosSimulatorArm64Test.dependsOn(this) | ||
| } | ||
| val iosTest by getting |
2 participants
Moved Android to v33
Moved iOS to v14.0
Moved app code from UIKit to fully SwiftUI
Fixed issue reported by Ilia Solovei.