Skip to content

Double escape \ in debugger file paths #1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KronicDeth merged 2 commits into from
Sep 18, 2020
Merged

Double escape \ in debugger file paths #1823

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
491cd8d
Double escape \ in debugger file paths
KronicDeth Sep 18, 2020
aad8f0b
Add #1823 to changelogs
KronicDeth Sep 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add #1823 to changelogs
  • Loading branch information
@KronicDeth
KronicDeth committed Sep 18, 2020
commit aad8f0b9dff386c0052a6d7acb5466f85aa51ace
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,8 @@
* [#1822](https://github.com/KronicDeth/intellij-elixir/pull/1822) - [@KronicDeth](https://github.com/KronicDeth)
* Vendor JInterface 1.11 to support `BIG_CREATION` when debugging.
The JInterface on Maven Central has stopped being updated because [the OTP Team didn't actually maintain it](https://bugs.erlang.org/browse/ERL-928?focusedCommentId=16521&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16521), that was Basho, and Basho is gone now. This version of JInterface, 1.11, is from Erlang 23.0.4 from Homebrew, but with the formula edited (`brew edit erlang`) to add `--with-java` and then built with `brew install erlang --build-from-source`.
* [#1823](https://github.com/KronicDeth/intellij-elixir/pull/1823) - [@KronicDeth](https://github.com/KronicDeth)
* On Windows, the `file.path` to the debugger server files has `\`, but they aren't escaped. Therefore, replace them with escaped version, `\\` to fix debugging on Windows, but leave Linux and macOS unaffected.

## v11.8.0
### Enhancements
Expand Down
5 changes: 5 additions & 0 deletions resources/META-INF/changelog.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@ <h1>v11.81.</h1>
Homebrew, but with the formula edited (<code>brew edit erlang</code>) to add <code>--with-java</code> and then
built with <code>brew install erlang --build-from-source</code>.
</li>
<li>
On Windows, the <code>file.path</code> to the debugger server files has <code>\</code>, but they aren't escaped.
Therefore, replace them with escaped version, <code>\\</code> to fix debugging on Windows, but leave Linux and
macOS unaffected.
</li>
</ul>
</li>
</ul>
Expand Down