Fix appimage

[Reflexe]

No description provided.

[Reflexe]

(Checks should pass after merge)

[PhysSong]

Previously, the script abused the word splitting to split multiple arguments in a environment variable. I think you should revert the last commit unless you can remove the abusing of that behavior properly.

[Reflexe]

I don't know why exactly, but it does not work anymore and docker will fail to parse arguments before my changes.

…

On Wed, 2 Oct 2019, 02:09 Hyunjin Song, ***@***.***> wrote: Previously, the script abused the word splitting to split multiple arguments in a environment variable. I think you should revert the last commit unless you can remove the abusing of that behavior properly. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#6?email_source=notifications&email_token=AFOMGKHEHUBR6MVORDGLSRTQMPKB7A5CNFSM4I4LYNGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEADBCOA#issuecomment-537268536>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFOMGKBC7JD5RGLSBFJEKRTQMPKB7ANCNFSM4I4LYNGA> .

[Reflexe]

See https://circleci.com/gh/Reflexe/lmms-ci-docker/17

…

On Wed, 2 Oct 2019, 02:17 Shmuel Hazan, ***@***.***> wrote: I don't know why exactly, but it does not work anymore and docker will fail to parse arguments before my changes. On Wed, 2 Oct 2019, 02:09 Hyunjin Song, ***@***.***> wrote: > Previously, the script abused the word splitting to split multiple > arguments in a environment variable. I think you should revert the last > commit unless you can remove the abusing of that behavior properly. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#6?email_source=notifications&email_token=AFOMGKHEHUBR6MVORDGLSRTQMPKB7A5CNFSM4I4LYNGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEADBCOA#issuecomment-537268536>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AFOMGKBC7JD5RGLSBFJEKRTQMPKB7ANCNFSM4I4LYNGA> > . >

[PhysSong]

Got it, you should restore the IFS to retain the splitting behavior.

[Reflexe]

This job is without any modification to the build file and still fails. Maybe build environment's docker image used to have bash for sh and it was changed recently.

…

On Wed, 2 Oct 2019, 03:14 Hyunjin Song, ***@***.***> wrote: Got it, you should restore the IFS to retain the splitting behavior. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#6?email_source=notifications&email_token=AFOMGKB5DM44KUOLOH2BOA3QMPRVRA5CNFSM4I4LYNGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEADENSQ#issuecomment-537282250>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFOMGKFMLGKNVU3YX2FQBUTQMPRVRANCNFSM4I4LYNGA> .