Proposed fix for 1150 Preset Browser: division between factory and user ... #1505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er files fails if factory has folders
Member
|
Nice, simple and sweet. I'll let @diizy merge this one. |
Member
|
Safe initialization of the new variable, good counter handling. Merging. |
tresf
added a commit
that referenced
this pull request
Jan 10, 2015
Proposed fix for 1150 Preset Browser: division between factory and user ...
Member
|
@curlymorphic can you take a look at #1925? It looks very closely related to the code in this PR (probably not caused by anything you did, just reaching out for help) :) |
Contributor
Author
|
sure :) |
This was referenced Nov 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #1150 Preset Browser: division between factory and user files fails if factory has folders
Simply added a counter to the Directory class. that is incremented for every child directory added.
Then used this counter to calc the position in tree of --Factory Presets --