Skip to content

Conversation

@zonkmachine
Copy link
Contributor

Since cee2871 the last of the user presets is listed first in the --- Factory files --- section.

@zonkmachine
Copy link
Contributor Author

I would push this directly but I don't know if this could behave differently depending on your OS.

@tresf
Copy link
Member

tresf commented Mar 11, 2016

I don't know if this could behave differently depending on your OS.

If it does cause issues, we'll put in an #ifdef retroactively and handle accordingly, but I can confirm this behavior on Windows.

image

On that note, it seems we have no such --- Factory files --- designation for root-level user presets...

image

@zonkmachine
Copy link
Contributor Author

On that note, it seems we have no such --- Factory files --- designation for root-level user presets...

But Is there really a need for it? We don't ship anything in there do we?

@tresf
Copy link
Member

tresf commented Mar 11, 2016

But Is there really a need for it? We don't ship anything in there do we?

Valid point (I think... 😄)

Off topic... when did github change the 👍 thumbsup icon? 😈

@zonkmachine
Copy link
Contributor Author

Off topic... when did github change the 👍 thumbsup icon? 😈

I don't know, but after moderating the Linux Mint forum for over a year I came to the conclusion that what people had trouble with most was.

  • icons
  • themes
  • wallpapers
  • combinations of the above mentioned subjects.

Don't mess with peoples icons... never ever.

zonkmachine added a commit that referenced this pull request Mar 11, 2016
File browser. Factory files off by one
@zonkmachine zonkmachine merged commit fadba1b into LMMS:master Mar 11, 2016
@zonkmachine
Copy link
Contributor Author

If it does cause issues, we'll put in an #ifdef retroactively and handle accordingly, but I can confirm this behavior on Windows.

Right. Merging...

@zonkmachine zonkmachine deleted the filebrowser branch March 11, 2016 19:27
@Fastigium
Copy link
Contributor

Yay for this! I've been annoyed by the factory files barrier being in the wrong place for a long time. Thanks for fixing 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants