Avoid crash on gui when rendering from command line and no write access #3322
+19
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The other option is to fix it in AudioFileDevice.cpp |
Contributor
Author
|
Pushed method two on a separate commit for comparison. I vote no. 2 |
zonkmachine
commented
Feb 4, 2017
| message = ExportProjectDialog::tr( "Could not open file %1 " | ||
| "for writing.\nPlease make " | ||
| "sure you have write-" | ||
| "permission to the file and " |
Contributor
Author
There was a problem hiding this comment.
write-permission?
-> write permission
zonkmachine
force-pushed
the
renderdirpermission
branch
from
e31c562 to
f9cb176
Compare
Contributor
Author
|
Settled for no.2 . Done... 🚂 |
tresf
approved these changes
Feb 4, 2017
jasp00
reviewed
Feb 4, 2017
src/core/audio/AudioFileDevice.cpp
Outdated
| } | ||
| else | ||
| { | ||
| printf( "%s\n", message.toUtf8().constData() ); |
zonkmachine
force-pushed
the
renderdirpermission
branch
from
f9cb176 to
21b52aa
Compare
Contributor
Author
|
Thanks! Merge... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2902
Something like this?