Skip to content

Fix issue #3339 by not clearing filter history on control change #3343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zonkmachine merged 1 commit into from
Mar 8, 2017
Merged

Fix issue #3339 by not clearing filter history on control change #3343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions plugins/CrossoverEQ/CrossoverEQ.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,23 +95,17 @@ bool CrossoverEQEffect::processAudioBuffer( sampleFrame* buf, const fpp_t frames
if( m_needsUpdate || m_controls.m_xover12.isValueChanged() )
{
m_lp1.setLowpass( m_controls.m_xover12.value() );
m_lp1.clearHistory();
m_hp2.setHighpass( m_controls.m_xover12.value() );
m_hp2.clearHistory();
}
if( m_needsUpdate || m_controls.m_xover23.isValueChanged() )
{
m_lp2.setLowpass( m_controls.m_xover23.value() );
m_lp2.clearHistory();
m_hp3.setHighpass( m_controls.m_xover23.value() );
m_hp3.clearHistory();
}
if( m_needsUpdate || m_controls.m_xover34.isValueChanged() )
{
m_lp3.setLowpass( m_controls.m_xover34.value() );
m_lp3.clearHistory();
m_hp4.setHighpass( m_controls.m_xover34.value() );
m_hp4.clearHistory();
}

// gain values update
Expand Down Expand Up @@ -206,6 +200,16 @@ bool CrossoverEQEffect::processAudioBuffer( sampleFrame* buf, const fpp_t frames
return isRunning();
}

void CrossoverEQEffect::clearFilterHistories()
{
m_lp1.clearHistory();
m_lp2.clearHistory();
m_lp3.clearHistory();
m_hp2.clearHistory();
m_hp3.clearHistory();
m_hp4.clearHistory();
}


extern "C"
{
Expand Down
2 changes: 2 additions & 0 deletions plugins/CrossoverEQ/CrossoverEQ.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ class CrossoverEQEffect : public Effect
{
return &m_controls;
}

void clearFilterHistories();

private:
CrossoverEQControls m_controls;
Expand Down
1 change: 1 addition & 0 deletions plugins/CrossoverEQ/CrossoverEQControls.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ void CrossoverEQControls::loadSettings( const QDomElement & elem )
m_mute4.loadSettings( elem, "mute4" );

m_effect->m_needsUpdate = true;
m_effect->clearFilterHistories();
}

void CrossoverEQControls::xover12Changed()
Expand Down