Ladspa plugin small memory leak fix #3496
Conversation
|
This patch is wrong because you are not supposed to free |
jasp00
left a comment
jasp00
left a comment
There was a problem hiding this comment.
You should try an approach that respects const.
| param_count = md->get_param_count(); // XXXKF ladspa_instance<Module>::real_param_count(); | ||
|
|
||
| const ladspa_plugin_info &plugin_info = md->get_plugin_info(); | ||
| std::string strName(plugin_info.name); |
There was a problem hiding this comment.
You should use spaces in this file.
| strcpy(Name, strName.c_str()); | ||
| descriptor.UniqueID = plugin_info.unique_id; | ||
| descriptor.Label = plugin_info.label; | ||
| descriptor.Name = strdup((std::string(plugin_info.name) + " LADSPA").c_str()); |
There was a problem hiding this comment.
strdup is fine. You just need to save the result somewhere else. It is not as efficient, but correctness is more important.
| delete []descriptor.PortNames; | ||
| delete []descriptor.PortDescriptors; | ||
| delete []descriptor.PortRangeHints; | ||
| delete []descriptor.Name; |
There was a problem hiding this comment.
You are not supposed to delete const memory.
| delete preset_descs; | ||
| free(descriptorForDssiName); | ||
| #endif | ||
| delete metadata; |
There was a problem hiding this comment.
metadata is const. You should go to the point where metadata is created, make sure you keep a reference, and release it on destruction; you may need a function with __attribute__((destructor)).
|
@devnexen I'm sorry this took so long to review, the original reviewer is no longer with the project. Calf has been moved to a submodule since #3940 and I missed this patch. Currently @JohannesLorenz is working on getting Calf updated to 0.90, so this patch could have a home in either the current 0.18~ish version on the Closing since the code this PR is against is no longer part of the LMMS codebase. |
4 participants
No description provided.