-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Replacement metronome samples #3513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Replacement metronome sounds :)
The background came from the splash screen
|
This keeps failing travis on mac ... 😕 |
@Mark-Agent003's branch is missing |
|
I'm confused. Is the Travis failing a problem, or are we good to go? |
|
The problem is unrelated so good from a CI perspective. |
|
Alright. What do I need to do? |
|
Nothing, just waiting on some to review and approve. We're a bit backlogged. |
|
@Mark-Agent003 Just noticed this also comes with a new tiled background although the PR doesn't set it by default. @RebeccaDeField, I'll defer this decision to you. |
|
I took a listen to the new metronome. I personally think the measure click is good but the beat click could use a bit of work. Perhaps using a slightly shorter, lower-pitch version of the measure click instead? |
|
@UnityParadox , do you like this better? I did exactly what you said, but I also made the measure click sound less like a bubble popping 😀 |
|
@Mark-Agent003 Indeed, much nicer! =) |
|
@Mark-Agent003 Thank you for your work on this 😊 I tested your background proposal and I think we're going to keep the bg simple and clean. Can you remove the additional background from this pull request so that it only includes your updates to the metronome? Please feel free to upload a version of the theme that includes your background on our Sharing Platform. |
|
Done. |
|
Can we get a second set of ears on this? I think the old version sound more like a metronome "click". Here's a zip containing both: |
|
The new click sounds more modern. The attack is enough for working with. I like it. |
|
I like the new one better too 👍 |
|
Great! 3 thumbs up. Merging. |
Replacement metronome sounds
Replacement metronome sounds
Replacement metronome sounds

Replacement metronome sounds