Skip to content

Conversation

@ollieperree
Copy link

Replaced "/at/" with "@", "/dot/" with "." etc.

Replaced "/at/" with "@", "/dot/" with "." etc.
@tresf
Copy link
Member

tresf commented Apr 28, 2017

@ollieperree this is done this way intentionally to thwart off email scrapers/bots. Can you please explain the purpose of this more?

@ollieperree
Copy link
Author

@tresf I just noticed that the format was inconsistent. Alternatively, the normal symbols could be substituted in when this file is displayed in the about dialog.

@tresf
Copy link
Member

tresf commented Apr 29, 2017

@ollieperree thanks for the attention to detail.

The AUTHORS file used to separate the software authors from the code contributors, but it's actually very inaccurate and outdated. We need to remove this file and simply keep the CONTRIBUTORS file, which is hanging out in purgatory for a while.

@Umcaruje
Copy link
Member

The AUTHORS file used to separate the software authors from the code contributors, but it's actually very inaccurate and outdated. We need to remove this file and simply keep the CONTRIBUTORS file, which is

Though some people are not in the contributors file, like the sample authors and some artwork authors. Also it doesn't really differentiate who did what like in the authors file.

@tresf
Copy link
Member

tresf commented Apr 29, 2017

We'll have to find a way to hack them into contributors. The maintenance task can do this.

In regards to what they contributed, I have a "who gives a ***" attitude because our most active contributors do a lot more than code LMMS let alone a specific feature.

Perhaps a compromise is to add a category each dev can pick that accompanies our mail map.

@tresf
Copy link
Member

tresf commented May 3, 2017

@ollieperree I'm going to request we close this since the file is so terribly outdated it really serves us no purpose to fix these without the sweeping changes mentioned above which rely on a maintenance task from our web server to be fixed first. Anyone's welcome to tackle this, but I don't really see a benefit in merging this PR as an interim step.

Although @Umcaruje brings a good point about what each person contributes, it's still quite misleading when it puts people like @eagles051387 in the listing. (Sorry Jonathan!)

In regards to the email formatting it was done as a sweeping change by Toby in 2006 when spam emails were prevelant (Gmail was released as a beta in 2004).

Furthermore, this inconsistency is all over the codebase as well. gmail.com vs gmail/dot/com and cleaning it up seems to have little or no value and is really up to the author. Some may not want an email exposed at all.

So although the project is perfectly fine removing the 11-year antiquated anti-spam measure, I'd rather see the time spent on fixing the contributors list.

@ollieperree ollieperree closed this May 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants