Provide support for fallback config values #3551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Tested this one out. |
Umcaruje
reviewed
May 13, 2017
Member
Umcaruje
left a comment
Umcaruje
left a comment
There was a problem hiding this comment.
Other than the two formatting issues, this looks good to me.
include/ConfigManager.h
Outdated
| const QString & attribute ) const; | ||
| const QString & value( const QString & cls, | ||
| const QString & attribute, | ||
| const QString & defaultVal) const; |
Member
There was a problem hiding this comment.
you should have a space between the parenthesis : defaultVal )
src/gui/SetupDialog.cpp
Outdated
| "syncvstplugins" ).toInt() ), | ||
| m_animateAFP(ConfigManager::inst()->value( "ui", | ||
| "animateafp").toInt() ), | ||
| "animateafp", "1").toInt() ), |
Member
Author
Formatting issues fixed. |
Umcaruje
approved these changes
May 13, 2017
PhysSong
pushed a commit
to PhysSong/lmms
that referenced
this pull request
Jul 8, 2017
Provide support for fallback config values Makes autosave and some other values checked by default. Supersedes LMMS#3541
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
Provide support for fallback config values Makes autosave and some other values checked by default. Supersedes LMMS#3541
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #3541 to address autosave regression #181 (comment).
Previous to this PR, there was no way to provide a "default on" style config value. The effect of this was variable names such as
disableautosavecausing double negatives in our codebase making it hard to read. Attempts to change them have resulted in a mismatch between desired default and actual default. This should allow config values to have default values.e.g.
Booleans are parsed as integers. A default value of
1will make a checkbox true. This will allow us to start moving toward more properly named variables as explained very well here #3088 (comment).