Skip to content

Fix loop condition in project rendering (#3105, #2030) #3576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Umcaruje merged 2 commits into from
May 29, 2017
Merged

Fix loop condition in project rendering (#3105, #2030) #3576

Umcaruje merged 2 commits into from
May 29, 2017

Conversation

@PhysSong
Copy link
Member

@PhysSong PhysSong commented May 26, 2017

Fix loop condition in ProjectRenderer::run().
It fixes #2030 clearly.
@DeRobyJ Could you test this for #3105?

Based on #3105 (comment)
(The idea from @softrabbit)

@qnebra
Copy link
Collaborator

qnebra commented May 27, 2017

Numerator automation fixed, but I don't know nothing about second issue.

Umcaruje
Umcaruje approved these changes May 29, 2017
View reviewed changes
Copy link
Member

@Umcaruje Umcaruje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this with all 3 export modes and it works perfectly 👍

@zonkmachine
Copy link
Contributor

zonkmachine commented May 29, 2017

Tested this with all 3 export modes and it works perfectly 👍

Then I suggest merging this. 🚜

@Umcaruje
Copy link
Member

Umcaruje commented May 29, 2017

👍

@Umcaruje Umcaruje merged commit 4ff091f into LMMS:stable-1.2 May 29, 2017
@Umcaruje Umcaruje mentioned this pull request May 29, 2017
Closed
@Umcaruje
Copy link
Member

Umcaruje commented May 29, 2017 •
edited
Loading

Thank you for your contribution @PhysSong !

PhysSong added a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017
@PhysSong
Fix loop condition in project rendering (LMMS#3105, LMMS#2030) (LMMS#…
c2b6f3c 
…3576)

* Change loop condition in ProjectRenderer::run()

* Remove Song::isExportDone()
PhysSong added a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017
@PhysSong
Fix loop condition in project rendering (LMMS#3105, LMMS#2030) (LMMS#…
ce9ea39 
…3576)

* Change loop condition in ProjectRenderer::run()

* Remove Song::isExportDone()
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
@PhysSong @Umcaruje
Fix loop condition in project rendering (LMMS#3105, LMMS#2030) (LMMS#…
8abadba 
…3576)

* Change loop condition in ProjectRenderer::run()

* Remove Song::isExportDone()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Umcaruje Umcaruje Umcaruje approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Numerator Automation

4 participants

@PhysSong @qnebra @zonkmachine @Umcaruje