Move the search bar on top of the file browser for sidebar pages (#3657) #3662
Conversation
|
@michaelgregorius thanks! Glad to see you doing this! |
|
@michaelgregorius Why the target is master, not stable-1.2? |
Because this is not a bug fix. |
|
Okay. |
…S#3657) Move the search bar on top of the file browser for the following sidebar windows: * "My Projects" * "My Samples" * "My Presets" * "My Home" * "My Computer" Add the greyed out text "Search" to the search text edit. The text is only shown as long as no text is entered in the search field. Also rename some variable names to something more meaningful. Rename the member m_l of FileBrowser to m_fileBrowserTreeWidget. Rename the following local variables in the constructor of FileBrowser: * ops -> searchWidget * opl -> searchWidgetLayout
michaelgregorius
force-pushed
the
3657-MoveSearchBar
branch
from
96b136f to
354c8dd
Compare
|
I have merged regardless of the failed builds as they seem to have been caused by problems with fetching the necessary packages for the build as can be seen here. The Linux build has built successfully on my machine and the changes were very limited, therefore I assume that everything is OK. By the way, is it possible to manually trigger another build without making any changes to the branch? |
Yes, for some of us at least... just click the Restart Job button. |
|
@tresf Thanks for the tip! I have checked with the old builds and it's not enabled for me. |
It should at least be visible for your own PRs, but I just looked at GitHub security and you're not in the admin group, you're in the developers group, Travis-CI must require project admin, I can't find a setting to override this. We can change access upon request, but that should be done offline. |
|
@tresf No need to change something. I guess we don't need to restart a build that often and in case it is needed urgently I will contact you. |
5 participants
Move the search bar on top of the file browser for the following sidebar windows:
Also rename some variable names to something more meaningful. Rename the member
m_lofFileBrowsertom_fileBrowserTreeWidget. Rename the following local variables in the constructor ofFileBrowser:ops->searchWidgetopl->searchWidgetLayout