Skip to content

UI: New behavior for the Plugin Browser #3773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tresf merged 10 commits into from
Nov 15, 2017
Merged

UI: New behavior for the Plugin Browser #3773

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4d2274f
WIP; sped up expansion of plugin descriptor widgets in the sidebar.
irrenhaus3 Jul 28, 2017
66803d0
WIP: List items expand much faster, but scrolling still feels weird.
irrenhaus3 Jul 31, 2017
fce7cfe
Remove widget resizing altogether, display plugin info in browser hea…
irrenhaus3 Aug 19, 2017
44bb028
Highlight Plugin desc widgets on mouseover
irrenhaus3 Aug 23, 2017
8ca29b2
TODO regarding desc height
irrenhaus3 Aug 23, 2017
4f0b3aa
Replaced one-time-use static function pluginBefore by Closure
irrenhaus3 Aug 23, 2017
c5df1dd
Fix QLabel include
irrenhaus3 Aug 23, 2017
189bdba
Use standard button highlight gradient in plugin browser widgets
irrenhaus3 Aug 24, 2017
84e053a
Show plugin details in tooltips instead of the browser header.
irrenhaus3 Aug 24, 2017
bd808e5
Remove unused include
irrenhaus3 Aug 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
WIP; sped up expansion of plugin descriptor widgets in the sidebar.
  • Loading branch information
@irrenhaus3
irrenhaus3 committed Aug 18, 2017
commit 4d2274fd61f3f9e0ef9d666c168e31630e416e5f
3 changes: 3 additions & 0 deletions include/PluginBrowser.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,9 @@ private slots:


private:
constexpr static int DEFAULT_HEIGHT{24};
constexpr static int HEIGHT_INCREMENT{4};

QTimer m_updateTimer;

const Plugin::Descriptor & m_pluginDescriptor;
Expand Down
12 changes: 6 additions & 6 deletions src/gui/PluginBrowser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ PluginDescWidget::PluginDescWidget( const Plugin::Descriptor & _pd,
m_pluginDescriptor( _pd ),
m_logo( _pd.logo->pixmap() ),
m_mouseOver( false ),
m_targetHeight( 24 )
m_targetHeight( DEFAULT_HEIGHT )
{
connect( &m_updateTimer, SIGNAL( timeout() ), SLOT( updateHeight() ) );
setFixedHeight( m_targetHeight );
Expand Down Expand Up @@ -160,7 +160,7 @@ void PluginDescWidget::paintEvent( QPaintEvent * e )
p.drawText( 10 + logo_size.width(), 15,
m_pluginDescriptor.displayName );

if( height() > 24 || m_mouseOver )
if( height() > DEFAULT_HEIGHT || m_mouseOver )
{
f.setBold( false );
p.setFont( f );
Expand All @@ -182,7 +182,7 @@ void PluginDescWidget::paintEvent( QPaintEvent * e )
void PluginDescWidget::enterEvent( QEvent * _e )
{
m_mouseOver = true;
m_targetHeight = height() + 1;
m_targetHeight = height() + HEIGHT_INCREMENT;
updateHeight();
QWidget::enterEvent( _e );
}
Expand All @@ -193,7 +193,7 @@ void PluginDescWidget::enterEvent( QEvent * _e )
void PluginDescWidget::leaveEvent( QEvent * _e )
{
m_mouseOver = false;
m_targetHeight = 24;
m_targetHeight = DEFAULT_HEIGHT;
updateHeight();
QWidget::leaveEvent( _e );
}
Expand All @@ -218,11 +218,11 @@ void PluginDescWidget::updateHeight()
{
if( m_targetHeight > height() )
{
setFixedHeight( height() + 1 );
setFixedHeight( height() + HEIGHT_INCREMENT );
}
else if( m_targetHeight < height() )
{
setFixedHeight( height() - 1 );
setFixedHeight( height() - HEIGHT_INCREMENT );
}
else
{
Expand Down