Skip to content

Fix "out of buffers" crash #3783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukas-w merged 9 commits into from
Sep 26, 2017
Merged

Fix "out of buffers" crash #3783

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b6421d4
Reimplement BufferManager
lukas-w Aug 29, 2017
6b557d2
Find Boost in CMake, fix Travis
lukas-w Aug 29, 2017
c11d12f
Remove BufferManager implementation
lukas-w Aug 30, 2017
9c91079
Revert "Find Boost in CMake, fix Travis"
lukas-w Aug 30, 2017
73728d7
Fix C++03 compatibility
lukas-w Aug 30, 2017
aebbe22
Fix code formatting inconsistencies
lukas-w Sep 17, 2017
70ac7db
Fix code formatting inconsistencies
lukas-w Sep 17, 2017
d1aa39b
Fix C++03 compatibility again
lukas-w Sep 17, 2017
93e4bd7
Fix conventions
PhysSong Sep 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Find Boost in CMake, fix Travis" 
Boost not used anymore.

This reverts commit 6b557d2.
  • Loading branch information
@lukas-w
lukas-w committed Aug 30, 2017
commit 9c91079337993b88efbcc7c1bf9577f3188a5932
2 changes: 1 addition & 1 deletion .travis/linux..install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
PACKAGES="cmake libsndfile-dev fftw3-dev libvorbis-dev libogg-dev libmp3lame-dev
libasound2-dev libjack-dev libsdl-dev libsamplerate0-dev libstk0-dev
libfluidsynth-dev portaudio19-dev wine-dev g++-multilib libfltk1.3-dev
libgig-dev libsoundio-dev libboost-dev"
libgig-dev libsoundio-dev"

# Help with unmet dependencies
PACKAGES="$PACKAGES libjack0"
Expand Down
2 changes: 1 addition & 1 deletion .travis/osx..install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env bash

PACKAGES="cmake pkgconfig boost fftw libogg libvorbis lame libsndfile libsamplerate jack sdl libgig libsoundio stk portaudio node fltk"
PACKAGES="cmake pkgconfig fftw libogg libvorbis lame libsndfile libsamplerate jack sdl libgig libsoundio stk portaudio node fltk"

if [ $QT5 ]; then
PACKAGES="$PACKAGES homebrew/versions/qt55"
Expand Down
4 changes: 0 additions & 4 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,10 +174,6 @@ ELSE()
INCLUDE("${QT_USE_FILE}")
ENDIF()

# check for boost
FIND_PACKAGE(Boost 1.54.0 REQUIRED)
INCLUDE_DIRECTORIES(${Boost_INCLUDE_DIRS})

# check for libsndfile
PKG_CHECK_MODULES(SNDFILE REQUIRED sndfile>=1.0.11)
IF(NOT SNDFILE_FOUND)
Expand Down