Fix sound while playing from piano roll, when BB tracks are muted #3804
+10
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Umcaruje
approved these changes
Sep 27, 2017
Member
Umcaruje
left a comment
Umcaruje
left a comment
There was a problem hiding this comment.
This works like a charm, and fixes both the bugs 👍
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
…MS#3804) * Don't set BB track for tracks not in the BB * Don't check for BB track mute state if we're playing a single pattern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1947, fixes #3379.
First commit fixes playback for patterns in main song. If a track is not in the
BBTrackContainer, we don't need to set parent BB track of play handle.Second commit is about pattens in BB. A pattern in BB editor won't be played if the parent BB track is muted. The only exception is playing the pattern in Piano-Roll. So this commit fixes this exceptional case.