Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
a09e8af
Setup dialog improvements.
Sep 2, 2017
e7de7e3
General improvements & correction of mistakes that prevented building.
Sep 5, 2017
3d22930
Fixed some typos.
Sep 10, 2017
4ca1534
Fixes.
Sep 14, 2017
d6c9fa4
Fixes and improvements.
Sep 21, 2017
26b5566
Fix.
Sep 21, 2017
481ca01
Fix.
Sep 22, 2017
61d2715
Fix build errors and warnings
PhysSong Sep 23, 2017
c6eafcb
UI improvements.
Sep 23, 2017
2479748
Code style improvements.
Sep 23, 2017
af37f6e
Fixes.
Oct 3, 2017
edac2ed
Fix.
Oct 4, 2017
1e502ac
Fix typos.
Oct 21, 2017
ab759dd
Geometry improvements.
Oct 25, 2017
8abe566
SF to SoundFont.
Nov 2, 2017
849650f
Revert "SF to SoundFont."
Nov 2, 2017
ded1765
Better restart warning. (WIP #1)
Dec 1, 2017
b95768c
Better restart warning. (WIP 2)
Dec 2, 2017
ed669db
Merge branch 'master' into SDI
Dec 21, 2017
1c9ff9a
Better look for plugins embedding settings.
Dec 21, 2017
0f52be7
Fix paths settings. (WIP 1)
Dec 22, 2017
cfb2ede
Merge branch 'master' into SDI
Mar 9, 2018
0c64f5f
Cosmetic fixes
Apr 23, 2018
09fcf1e
Fix paths settings
Apr 23, 2018
ecafce6
Buffer size is a setting that requires restarting...
Apr 24, 2018
389b60e
Fix `changeLang` connection
Apr 24, 2018
ca7dbbb
Fix crash introduced by 389b60e
May 1, 2018
2c14e1a
Take advantage of setSpacing()
May 6, 2018
8689e51
Remove useless context help button
May 6, 2018
8f14382
Fix some comments
May 6, 2018
0d641c0
Some fixes
May 16, 2018
87fec93
Remove STK related code from ConfigManager...
May 17, 2018
9687783
Merge branch 'master' into SDI
PhysSong May 18, 2018
3fc8e86
Merge branch 'master' into SDI
husamalhomsi Jun 5, 2018
d4f8338
Fixup merge
PhysSong Jun 6, 2018
8bec799
Merge branch 'master' into SDI
PhysSong Dec 26, 2018
196e412
Revert "Remove STK related code from ConfigManager..."
husamalhomsi Dec 27, 2018
5838bf7
Fix revert
husamalhomsi Dec 27, 2018
6a1862a
Merge branch 'master' into SDI
husamalhomsi Jun 12, 2019
045c7af
Fix
husamalhomsi Jun 12, 2019
548cbad
Fix
husamalhomsi Jun 12, 2019
d22c33a
Fixes
husamalhomsi Jun 12, 2019
abda9e3
Use a single counter for positioning LedCeckBoxes
husamalhomsi Jun 13, 2019
c45451f
Fix position of some LedCheckBoxes
husamalhomsi Jun 13, 2019
0bbd589
Sort includes alphabetically
husamalhomsi Jun 13, 2019
3c05c73
Misc. style fixes
husamalhomsi Jun 13, 2019
1dfba29
Shorten restart warning to fit
husamalhomsi Jun 13, 2019
e9f96cd
Some settings should not show restart warning
husamalhomsi Jun 13, 2019
832832b
Fix previous commit
husamalhomsi Jun 13, 2019
25b0a2b
Revise arrangement and wording
husamalhomsi Jun 14, 2019
629b1e4
Fix regression
husamalhomsi Jun 14, 2019
23da154
Simpler way to set WindowContextHelpButtonHint off
husamalhomsi Jun 15, 2019
8c5a88c
Revert previous commit for compatibility
husamalhomsi Jun 15, 2019
201d336
Fix latest merge
husamalhomsi Jun 30, 2019
5f31fa5
Fix
husamalhomsi Jun 30, 2019
51fff61
Nitpick
husamalhomsi Sep 5, 2019
5fb7c30
Typo
husamalhomsi Sep 5, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Setup dialog improvements.
  • Loading branch information
Hussam Eddin Alhomsi authored and PhysSong committed Sep 23, 2017
commit a09e8af3c48008639a248ebb58b65c5b55f490d9
6 changes: 3 additions & 3 deletions src/gui/AudioDeviceSetupWidget.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@

#include "AudioDeviceSetupWidget.h"

AudioDeviceSetupWidget::AudioDeviceSetupWidget( const QString & _caption, QWidget * _parent ) :
TabWidget( TabWidget::tr( "Settings for %1" ).arg(TabWidget::tr( _caption.toLatin1() ) ).toUpper(),
_parent )
AudioDeviceSetupWidget::AudioDeviceSetupWidget(const QString & caption, QWidget * parent) :
TabWidget(TabWidget::tr("Settings for %1").arg(TabWidget::tr(caption.toLatin1())),
parent)
{
}

Expand Down
28 changes: 14 additions & 14 deletions src/gui/MidiSetupWidget.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -29,38 +29,38 @@
#include "ConfigManager.h"
#include "gui_templates.h"

MidiSetupWidget::MidiSetupWidget( const QString & caption, const QString & configSection,
const QString & devName, QWidget * parent ) :
TabWidget( TabWidget::tr( "Settings for %1" ).arg(
tr( caption.toLatin1() ) ).toUpper(), parent ),
MidiSetupWidget::MidiSetupWidget(const QString & caption, const QString & configSection,
const QString & devName, QWidget * parent) :
TabWidget(TabWidget::tr("Settings for %1").arg(
tr(caption.toLatin1())), parent),
m_configSection(configSection),
m_device(nullptr)
{
// supply devName=QString::Null() (distinct from QString(""))
// to indicate that there is no editable DEVICE field
// Supply devName=QString::Null() (distinct from QString(""))
// to indicate that there is no editable device field.
if (!devName.isNull())
{
m_device = new QLineEdit( devName, this );
m_device->setGeometry( 10, 20, 160, 20 );
m_device = new QLineEdit(devName, this);
m_device->setGeometry(10, 20, 160, 20);

QLabel * dev_lbl = new QLabel( tr( "DEVICE" ), this );
dev_lbl->setFont( pointSize<7>( dev_lbl->font() ) );
dev_lbl->setGeometry( 10, 40, 160, 10 );
QLabel * dev_lbl = new QLabel(tr("Device"), this);
dev_lbl->setFont(pointSize<7>(dev_lbl->font()));
dev_lbl->setGeometry(10, 40, 160, 10);
}
}

void MidiSetupWidget::saveSettings()
{
if (!m_configSection.isEmpty() && m_device)
{
ConfigManager::inst()->setValue( m_configSection, "device",
m_device->text() );
ConfigManager::inst()->setValue(m_configSection, "device",
m_device->text());
}
}

void MidiSetupWidget::show()
{
// the setup widget should only be visible if the device has some configurable attributes
// The setup widget should only be visible if the device has some configurable attributes.
bool visible = !m_configSection.isEmpty();
parentWidget()->setVisible(visible);
QWidget::setVisible(visible);
Expand Down
Loading