Skip to content

About dialog & export dialog improvements. #3826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tresf merged 14 commits into from
Nov 15, 2017
Merged

About dialog & export dialog improvements. #3826

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
1c31bb5
Initial commit.
Sep 25, 2017
d1e2815
Fixes.
Sep 25, 2017
b1cc942
Some about dialog changes.
Sep 26, 2017
b2ea361
Change color of link to something green-ish.
Sep 26, 2017
0404639
Commeneted out useless code.
Sep 26, 2017
1da95ba
Formatting reverse.
Sep 27, 2017
015f4c9
Formatting reverse 2.
Sep 27, 2017
080c8b4
Formatting reverse 3.
Sep 27, 2017
4398747
Return "Involved" tab. Revert AboutDialog.cpp changes.
Sep 27, 2017
351c8ca
Commented out "Export as loop".
Sep 30, 2017
10f4924
Undo commented out "Export as loop".
Sep 30, 2017
9da7ae6
ED: (Remove end silence) -> (Remove extra bar).
Oct 26, 2017
bb43f97
Export dialog should not be resizable.
Oct 27, 2017
aa589fa
"LMMS developers" to "LMMS Developers".
Nov 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Some about dialog changes.
  • Loading branch information
Hussam Eddin Alhomsi committed Sep 26, 2017
commit b1cc94233ea6837c7276c958ddc6c9162eddb179
6 changes: 3 additions & 3 deletions src/gui/AboutDialog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,9 @@ AboutDialog::AboutDialog(QWidget* parent) :
authorLabel->setPlainText(
embed::getText("AUTHORS"));

/*involvedLabel->setPlainText(
Copy link
Copy Markdown
Member

@Umcaruje Umcaruje Sep 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you disable the contributors file, it contains all of our github contributors and it's more accurate than the authors file (though the authors file contains some people that wouldn't be credited through github)

Copy link
Copy Markdown
Member

@lukas-w lukas-w Sep 27, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it contains all of our github contributors

@Umcaruje Not anymore, jasp00 removed the CMake logic that used to create the file in 30f1e52. He planned to replace that by a maintenance task on our server, but it appears it was never implemented correctly. That's probably why @Sawuare removed it. Related: LMMS/lmms.io/pull/198, #3016

Copy link
Copy Markdown
Member

@Umcaruje Umcaruje Sep 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then, should we update the authors file with some missing people? Or revert @jasp00's changes, since he sent a mail saying he won't be able to contribute for some time.

Copy link
Copy Markdown
Member Author

@husamalhomsi husamalhomsi Sep 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know the story of the contributors tab. I just removed it because it didn't display anything other than: "Contributors ordered by number of commit:".

embed::getText("CONTRIBUTORS"));*/

licenseLabel->setPlainText(
embed::getText("LICENSE.txt"));

involvedLabel->setPlainText(
embed::getText("CONTRIBUTORS"));
}
10 changes: 6 additions & 4 deletions src/gui/dialogs/about_dialog.ui
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@
<rect>
<x>0</x>
<y>0</y>
<width>558</width>
<height>358</height>
<width>500</width>
<height>270</height>
</rect>
</property>
<property name="minimumSize">
<size>
<width>558</width>
<height>358</height>
<width>500</width>
<height>270</height>
</size>
</property>
<property name="windowTitle">
Expand Down Expand Up @@ -202,6 +202,7 @@
</item>
</layout>
</widget>
<!--
<widget class="QWidget" name="tab_3">
<attribute name="title">
<string>Involved</string>
Expand All @@ -223,6 +224,7 @@
</item>
</layout>
</widget>
-->
<widget class="QWidget" name="Seite">
<attribute name="title">
<string>Translation</string>
Expand Down