Skip to content

Conversation

@tresf
Copy link
Member

@tresf tresf commented Nov 14, 2017

Attempts to fix the Travis-CI environment by patching exprtk to workaround a bug with Clang.

More information about the bug is here: #3965 (comment)

@tresf tresf changed the title Patch exprtk on Clang < 3.9 Patch exprtk on Clang Nov 14, 2017
@tresf tresf merged commit 28a4eb2 into LMMS:master Nov 14, 2017
@lukas-w
Copy link
Member

lukas-w commented Nov 23, 2017

@tresf I get this error on the fix/msvc branch (#4000), even though it includes your patch: https://travis-ci.org/LMMS/lmms/jobs/305976591#L7078

/Users/travis/build/LMMS/lmms/plugins/Xpressive/exprtk/exprtk.hpp:1965:64: error: default initialization of an object of const type 'const typename numeric::details::number_type<double>::type' (aka 'const exprtk::details::numeric::details::real_type_tag') without a user-provided default constructor

         const typename numeric::details::number_type<T>::type num_type;

                                                               ^`

Any idea what's going wrong here?

@tresf
Copy link
Member Author

tresf commented Nov 24, 2017

Just a formal follow-up...

As discussed on Discord, it appears Clang is now AppleClang and the fix is to use MATCHES instead of the current STREQUALS in plugins/Xpressive/CMakeLists.txt. This was likely caused by an XCode upgrade on the Travis-CI side.

https://github.com/tresf/lmms/blob/ffaba04be1a54308d7c7adccaf2397b1a92a3c78/plugins/Xpressive/CMakeLists.txt#L13-L14

Also note, upstream has plans to permanently fix this, so the workaround should be temporary.

sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants