Skip to content

Conversation

@PhysSong
Copy link
Member

Fixes #3952 by passing true to putValue()'s ignoreSurroundingPoint argument.
Its default value is false, which makes positions of automation points incorrect or remove some points which should stay on its position. Thus, passing true fixes this problem.

Copy link
Contributor

@zonkmachine zonkmachine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will work for sure. I still can't test this but the code is solid.

@zonkmachine
Copy link
Contributor

I looked at the other instances of putValue(...) and I seem to have missed more than these ones and will have another look.

@PhysSong
Copy link
Member Author

@zonkmachine As far as I know, ignoreSurroundingPoints is not used except in automation editor. I think its default value should be true(the behavior before the argument is introduced).

@zonkmachine
Copy link
Contributor

I think its default value should be true(the behavior before the argument is introduced).

Agreed. const bool ignoreSurroundingPoints = true );. That's the original behavior and where it's needed we already pass controlKey.

@PhysSong
Copy link
Member Author

Okay. Is it better to drop current commit and change the default value instead?

@zonkmachine
Copy link
Contributor

Yes, I think so. This looks like a one-liner. I did a quick test and it worked fine.

@PhysSong
Copy link
Member Author

@zonkmachine I just pushed new commit.

@PhysSong PhysSong changed the title Fix automation pattern flipping with coarse quantization Fix automation pattern bugs related to quantization Nov 18, 2017
@PhysSong PhysSong changed the title Fix automation pattern bugs related to quantization Fix automation pattern regressions in #3352 Nov 18, 2017
Copy link
Contributor

@zonkmachine zonkmachine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still approved. Tested, works well.

@PhysSong PhysSong merged commit 514ae34 into LMMS:stable-1.2 Nov 19, 2017
@PhysSong PhysSong deleted the autoflip branch November 19, 2017 01:50
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Change the default value of ignoreSurroundingPoints in AutomationPattern::putValue to true, which was false in LMMS#3352.
Fixes automation filpping bug and some potential issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automation Editor crashed/freezed

2 participants