-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix automation pattern regressions in #3352 #3977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
zonkmachine
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will work for sure. I still can't test this but the code is solid.
|
I looked at the other instances of putValue(...) and I seem to have missed more than these ones and will have another look. |
|
@zonkmachine As far as I know, |
Agreed. |
|
Okay. Is it better to drop current commit and change the default value instead? |
|
Yes, I think so. This looks like a one-liner. I did a quick test and it worked fine. |
|
@zonkmachine I just pushed new commit. |
zonkmachine
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still approved. Tested, works well.
Change the default value of ignoreSurroundingPoints in AutomationPattern::putValue to true, which was false in LMMS#3352. Fixes automation filpping bug and some potential issues.
Fixes #3952 by passing
truetoputValue()'signoreSurroundingPointargument.Its default value is
false, which makes positions of automation points incorrect or remove some points which should stay on its position. Thus, passingtruefixes this problem.