Skip to content

Limit note length to quantization value #3998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zonkmachine wants to merge 3 commits into from
Closed

Limit note length to quantization value #3998

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa08c52
Limit note length to quantization value
zonkmachine Nov 22, 2017
54e4bc5
Update src/gui/editors/PianoRoll.cpp
zonkmachine May 11, 2020
cb01991
Remember min note length if shorter than quantization()
zonkmachine May 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/gui/editors/PianoRoll.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2811,8 +2811,8 @@ void PianoRoll::dragNotes( int x, int y, bool alt, bool shift, bool ctrl )
if (note->selected())
{
int newLength = note->oldLength() + off_ticks;
newLength = qMax(1, newLength);
note->setLength( MidiTime(newLength) );
newLength = qMax(alt ? 1 : quantization(), newLength);
Copy link
Member

@Spekular Spekular May 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation for my preferred behavior, since code might be easier to interpret than my explanation 😅

Suggested change
newLength = qMax(alt ? 1 : quantization(), newLength);
if (newLength <= 0) { newLength = quantization(); }

Or if you prefer

Suggested change
newLength = qMax(alt ? 1 : quantization(), newLength);
newLength = (newLength > 0) ? newLength : quantization();

Copy link
Contributor Author

@zonkmachine zonkmachine May 11, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's elegant! I prefer the <Alt> key in there somewhere. You can skip quantization when changing the length of the note with the <Alt> key so I would prefer:

if (newLength <= 0){ newLength = alt ? 1 : quantization(); }

If you change that I'll commit it.

Copy link
Member

@Spekular Spekular May 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like so? :)

Suggested change
newLength = qMax(alt ? 1 : quantization(), newLength);
if (newLength <= 0) { newLength = alt ? 1 : quantization(); }

Copy link
Contributor Author

@zonkmachine zonkmachine May 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup!

Copy link
Contributor

@Veratil Veratil May 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder that newLength = alt is not a boolean operation, but an assignment one. 😉

Copy link
Contributor Author

@zonkmachine zonkmachine May 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We're assigning either the quantized value or if overriding with Alt key, 1. Then you can still set the note to any length if you want.

Copy link
Contributor

@Veratil Veratil May 11, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay! Wanted to make sure since tertiary operator can be confusing sometimes.
EDIT: To quick glance that is. 😁 Looked like newLength == alt ? ... when I saw it.

note->setLength(MidiTime(newLength));

m_lenOfNewNotes = note->length();
}
Expand Down