Skip to content

Change Detune To Pitch Bend in Piano Roll For Stable-1.2 #4194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
husamalhomsi merged 39 commits into from
Mar 19, 2018
Merged

Change Detune To Pitch Bend in Piano Roll For Stable-1.2 #4194

Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
1d34e94
Change Detune To Pitch Bend in Piano Roll
Anonymouqs Feb 26, 2018
37c5fdf
Fix Detune Mode To Pitch Bend Mode Fi
Anonymouqs Feb 26, 2018
1f8a502
Decapitalize m in Pitch Bend Mode
Anonymouqs Feb 27, 2018
238c824
Change internal references of detune to Pitch Bend in Piano Roll and …
Anonymouqs Mar 7, 2018
4b57db2
Add final detune to pitchbend replacements
Anonymouqs Mar 7, 2018
76f182b
Replace DETUNING with PITCHBEND
Anonymouqs Mar 8, 2018
9dfea35
Fix InstrumentFunctions.cpp
Anonymouqs Mar 8, 2018
748c69a
Fix DetuningReferences (again)
Anonymouqs Mar 8, 2018
34fd806
Another fix
Anonymouqs Mar 9, 2018
59b3998
Audio File Processor reference fix
Anonymouqs Mar 9, 2018
732f801
Thank you programming gods
Anonymouqs Mar 9, 2018
ae78a7b
Fix Patman Reference glitch
Anonymouqs Mar 9, 2018
953d4ad
More references
Anonymouqs Mar 9, 2018
c463660
Fix automation track test
Anonymouqs Mar 9, 2018
5c98f79
Revert "Thank you programming gods"
Anonymouqs Mar 9, 2018
f49849b
Fix Automation Track Test
Anonymouqs Mar 9, 2018
ef70809
Final Fix
Anonymouqs Mar 9, 2018
733853e
Revert "Decapitalize m in Pitch Bend Mode"
Anonymouqs Mar 19, 2018
2c8586d
Revert "Change internal references of detune to Pitch Bend in Piano R…
Anonymouqs Mar 19, 2018
6ea5bd5
Revert "Add final detune to pitchbend replacements"
Anonymouqs Mar 19, 2018
beaf5f5
Revert "Replace DETUNING with PITCHBEND"
Anonymouqs Mar 19, 2018
cac7552
Revert "Fix DetuningReferences (again)"
Anonymouqs Mar 19, 2018
dfdf808
Revert "Another fix"
Anonymouqs Mar 19, 2018
85958d2
Revert "Audio File Processor reference fix"
Anonymouqs Mar 19, 2018
f01cb71
Revert "Fix Patman Reference glitch"
Anonymouqs Mar 19, 2018
43162e6
Revert "Fix automation track test"
Anonymouqs Mar 19, 2018
d85452d
Revert "Fix Automation Track Test"
Anonymouqs Mar 19, 2018
d6c1d90
Revert "Final Fix"
Anonymouqs Mar 19, 2018
c5cd01c
Revert "Fix InstrumentFunctions.cpp"
Anonymouqs Mar 19, 2018
699a12e
Revert "Revert "Fix automation track test""
Anonymouqs Mar 19, 2018
c119058
Revert "Revert "Revert "Fix automation track test"""
Anonymouqs Mar 19, 2018
c713d38
Reverts Internal Changes
Anonymouqs Mar 19, 2018
f95031a
Revert "Reverts Internal Changes"
Anonymouqs Mar 19, 2018
9ac2b34
Revert "Revert "Reverts Internal Changes""
Anonymouqs Mar 19, 2018
c0bd032
Fix
Anonymouqs Mar 19, 2018
2b04141
FIx
Anonymouqs Mar 19, 2018
eb4cdb3
Revert Changes
Anonymouqs Mar 19, 2018
9414e0c
Revert "Revert "Decapitalize m in Pitch Bend Mode""
Anonymouqs Mar 19, 2018
ebc9591
Merge branch 'DetuneToPitchBend-Stable-1.2' of https://github.com/Ano…
Anonymouqs Mar 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/gui/editors/PianoRoll.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4077,14 +4077,14 @@ PianoRollWindow::PianoRollWindow() :
QAction* drawAction = editModeGroup->addAction( embed::getIconPixmap( "edit_draw" ), tr( "Draw mode (Shift+D)" ) );
QAction* eraseAction = editModeGroup->addAction( embed::getIconPixmap( "edit_erase" ), tr("Erase mode (Shift+E)" ) );
QAction* selectAction = editModeGroup->addAction( embed::getIconPixmap( "edit_select" ), tr( "Select mode (Shift+S)" ) );
QAction* detuneAction = editModeGroup->addAction( embed::getIconPixmap( "automation" ), tr("Detune mode (Shift+T)" ) );
QAction* pitchBendAction = editModeGroup->addAction( embed::getIconPixmap( "automation" ), tr("Detune mode (Shift+T)" ) );
Copy link
Member

@tresf tresf Feb 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to change the text for this as well?

Copy link
Contributor Author

@Anonymouqs Anonymouqs Feb 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, so the source code is clearer.

Copy link
Member

@tresf tresf Feb 26, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anonymouqs I do not understand your reply. Did you make a mistake and forget this line? Will you fix it? (Hint, the text still reads "Detune mode (Shift+T)")


drawAction->setChecked( true );

drawAction->setShortcut( Qt::SHIFT | Qt::Key_D );
eraseAction->setShortcut( Qt::SHIFT | Qt::Key_E );
selectAction->setShortcut( Qt::SHIFT | Qt::Key_S );
detuneAction->setShortcut( Qt::SHIFT | Qt::Key_T );
pitchBendAction->setShortcut( Qt::SHIFT | Qt::Key_T );

drawAction->setWhatsThis(
tr( "Click here and draw mode will be activated. In this "
Expand Down Expand Up @@ -4112,7 +4112,7 @@ PianoRollWindow::PianoRollWindow() :
#else
"Ctrl" ) );
#endif
detuneAction->setWhatsThis(
pitchBendAction->setWhatsThis(
tr( "Click here and detune mode will be activated. "
"In this mode you can click a note to open its "
"automation detuning. You can utilize this to slide "
Expand All @@ -4127,7 +4127,7 @@ PianoRollWindow::PianoRollWindow() :
notesActionsToolBar->addAction( drawAction );
notesActionsToolBar->addAction( eraseAction );
notesActionsToolBar->addAction( selectAction );
notesActionsToolBar->addAction( detuneAction );
notesActionsToolBar->addAction( pitchBendAction );
notesActionsToolBar->addSeparator();
notesActionsToolBar->addAction( quantizeAction );

Expand Down