Fix some bugs with LFO waveform drag&drop #4227
Merged
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update LFO waveform display after dropping a sample file * Fix broken drag&drop from sample tracks
Contributor
Nice catch! |
zonkmachine
approved these changes
Mar 8, 2018
Member
Author
|
Maybe out of scope, but is it better to activate user-wave mode automatically when a sample file is dropped? |
Contributor
Yes. That would be better. |
Member
Author
Done via e4f0d25. |
Contributor
Better. |
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
* Change to user-wave mode and update display after dropping a sample * Fix broken drag&drop from sample tracks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update LFO waveform display after dropping a sample file. Fixes #3307.
This PR also fixes a broken functionality, "drag&drop from sample tracks".