Skip to content

Fix VST effect bugs #4294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhysSong merged 11 commits into from
May 30, 2018
Merged

Fix VST effect bugs #4294

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9449c07
Fix VST sub-window creation glitches in project loading
lukas-w Feb 10, 2018
bf98758
Fix effect dialog layout glitches
lukas-w Feb 10, 2018
3eb5815
Fix X11 embedding on Qt4
DomClark Mar 24, 2018
c5f80d4
Fix VST effect load crash on non-primary monitor
DomClark Apr 12, 2018
2a35d5e
Fix toggling UI for non-embedded VST effects
DomClark Apr 12, 2018
61ac18a
Preserve VST GUI positions and keep them on top
DomClark Apr 20, 2018
be589fe
Minor fixes
DomClark Apr 20, 2018
cee327e
VST: Add workaround for small effect window on project load
lukas-w Apr 29, 2018
cbf8cbd
Fix RemoteVstPlugin not exiting when effect removed
PhysSong May 20, 2018
d6ae46e
Allow controlling VST effects without own GUI
PhysSong May 20, 2018
211241f
Fix crash when re-opening VST effect manage dialog
PhysSong May 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix effect dialog layout glitches 
QMdiSubWindow::setSizePolicy doesn't have any effect because QMdiSubWindow
uses a layout. This patch uses QMdiSubWindow::layout()->setSizeConstraint
instead. This may cause effects that don't have a layout and don't
implement sizeHint() to now be resizable. For effects that do though, it
fixes the size constraint.
  • Loading branch information
@lukas-w @PhysSong
lukas-w authored and PhysSong committed May 21, 2018
commit bf987583589f4f633a408b718a6b4a62bcac9cda
5 changes: 4 additions & 1 deletion src/gui/widgets/EffectView.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
#include <QMdiSubWindow>
#include <QPainter>
#include <QWhatsThis>
#include <QLayout>

#include "EffectView.h"
#include "DummyEffect.h"
Expand Down Expand Up @@ -109,7 +110,9 @@ EffectView::EffectView( Effect * _model, QWidget * _parent ) :
{
m_subWindow = gui->mainWindow()->addWindowedWidget( m_controlView );
m_subWindow->setSizePolicy( QSizePolicy::Fixed, QSizePolicy::Fixed );
m_subWindow->setFixedSize( m_subWindow->size() );
if (m_subWindow->layout()) {
m_subWindow->layout()->setSizeConstraint(QLayout::SetFixedSize);
}
Copy link
Copy Markdown
Member

@PhysSong PhysSong Apr 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukas-w I don't know if it's needed, but isn't it safe to keep previous behavior(probably with else)?

Copy link
Copy Markdown
Member

@lukas-w lukas-w Apr 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PhysSong I don't think it's needed, setSizePolicy( QSizePolicy::Fixed, QSizePolicy::Fixed ) already does that in the else case.


Qt::WindowFlags flags = m_subWindow->windowFlags();
flags &= ~Qt::WindowMaximizeButtonHint;
Expand Down