Skip to content

Responsive "Effects chain" & "User controller" LEDs #4297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
husamalhomsi merged 6 commits into from
Apr 24, 2018
Merged

Responsive "Effects chain" & "User controller" LEDs #4297

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
eb14417
Turn off the effects chain LED when its chain is empty
Apr 11, 2018
2a03050
Turn on the user controller LED when a controller is selected
Apr 15, 2018
d3e65ca
From EffectRackView to EffectChain
Apr 17, 2018
af6c0e3
Remove unused function: setEnabled()
Apr 17, 2018
def9ac2
Merge branch 'master' into LEDS
Apr 17, 2018
f0002c0
Fix
Apr 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/gui/widgets/EffectRackView.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,10 @@ void EffectRackView::deletePlugin( EffectView* view )
Effect * e = view->effect();
m_effectViews.erase( qFind( m_effectViews.begin(), m_effectViews.end(), view ) );
delete view;
if( m_effectViews.size() == 0 )
{
fxChain()->m_enabledModel.setValue( false );
}
Copy link
Member

@PhysSong PhysSong Apr 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since EffectChain::clear already have the same functionality, I think you can implement this in EffectChain::removeEffect instead.

Copy link
Member Author

@husamalhomsi husamalhomsi Apr 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in d3e65ca

fxChain()->removeEffect( e );
e->deleteLater();
update();
Expand Down