Skip to content

Ensure flanger LFO starts at the same position on render #4360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
josh-audio wants to merge 3 commits into from
Closed

Ensure flanger LFO starts at the same position on render #4360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96e2ca9
Restart flanger LFO on Song::playbackStateChanged signal
josh-audio May 16, 2018
3058b0e
Clean up
josh-audio May 16, 2018
b389f18
Remove unnecessary include
josh-audio May 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions plugins/Flanger/FlangerControls.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ FlangerControls::FlangerControls( FlangerEffect *effect ) :

{
connect( Engine::mixer(), SIGNAL( sampleRateChanged() ), this, SLOT( changedSampleRate() ) );
connect( Engine::getSong(), SIGNAL( playbackStateChanged() ), this, SLOT( changedPlaybackState() ) );
}


Expand Down Expand Up @@ -81,3 +82,10 @@ void FlangerControls::changedSampleRate()
}



void FlangerControls::changedPlaybackState()
{
m_effect->restartLFO();
}


1 change: 1 addition & 0 deletions plugins/Flanger/FlangerControls.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ class FlangerControls : public EffectControls

private slots:
void changedSampleRate();
void changedPlaybackState();

private:
FlangerEffect* m_effect;
Expand Down
9 changes: 8 additions & 1 deletion plugins/Flanger/FlangerEffect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ bool FlangerEffect::processAudioBuffer( sampleFrame *buf, const fpp_t frames )
if(invertFeedback)
{
m_lDelay->tick( &buf[f][1] );
m_rDelay->tick(&buf[f][0] );
m_rDelay->tick( &buf[f][0] );
} else
{
m_lDelay->tick( &buf[f][0] );
Expand All @@ -139,6 +139,13 @@ void FlangerEffect::changeSampleRate()



void FlangerEffect::restartLFO()
{
m_lfo->restart();
}



extern "C"
{

Expand Down
1 change: 1 addition & 0 deletions plugins/Flanger/FlangerEffect.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ class FlangerEffect : public Effect
return &m_flangerControls;
}
void changeSampleRate();
void restartLFO();

private:
FlangerControls m_flangerControls;
Expand Down
6 changes: 6 additions & 0 deletions plugins/Flanger/QuadratureLfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,12 @@ class QuadratureLfo



inline void restart()
{
m_phase = 0;
}



inline void setSampleRate ( int samplerate )
{
Expand Down