Skip to content

Fix MSVC VST compilation #4421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lukas-w wants to merge 35 commits into from
Closed

Fix MSVC VST compilation #4421

Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
884601f
Use CMake GenerateExportHeader
lukas-w Nov 24, 2017
74d4b2f
CMake: Fix MSVC architecture detection
lukas-w Nov 26, 2017
81a0ec3
MSVC: Port RemoteVstPlugin
lukas-w Nov 26, 2017
c41d59b
RemoteVstPlugin: Debug LoadLibrary failure
lukas-w Nov 26, 2017
2b1b3d3
MSVC: Fix VST build
lukas-w Nov 26, 2017
b416036
VST: Fix main entry calling convention
lukas-w Nov 26, 2017
9c35487
Linux compile fixes
lukas-w Nov 26, 2017
c3d0dc5
Fix Linux VST compilation
lukas-w Nov 26, 2017
e95a587
MSVC: Fix VST arch detection
lukas-w Nov 26, 2017
e644202
MSVC: Fix RemoteVstPlugin module path
lukas-w Nov 26, 2017
8fce500
VST build fixes
lukas-w Nov 27, 2017
f702738
CMake quoting fixes
lukas-w Nov 27, 2017
5b9579d
MinGW fixes
lukas-w Nov 28, 2017
9a9580a
Fix export errors with MinGW
lukas-w Nov 28, 2017
a0bd296
Mingw64 compilation fixes
lukas-w Nov 28, 2017
39d83ee
More export fixes
lukas-w Nov 28, 2017
be0c02f
Fix 64bit VSTs on Linux by fixing callback calling convention
lukas-w Jan 14, 2018
5744c2a
CMake: Fix Clang detection
lukas-w May 9, 2018
3beac2c
MSVC fixes (#4352)
May 22, 2018
9db8cbf
Enable 64bit VSTs on Linux
lukas-w Jun 7, 2018
cd35ec2
MSVC VST compilation fixes
lukas-w Jun 11, 2018
225e902
AudioSdl: Add support for full SDL2 with float samples and recording
Reflexe Nov 7, 2017
aa2c867
AudioSDL -> SDL2: Fix a crash from calling a SDL1 function instead of
Reflexe Dec 21, 2017
3d98b0a
Fix cherry-pick
lukas-w Jun 11, 2018
ad4c4f0
AudioSdl: Use NULL for device names in order to get the default device.
lukas-w Jun 11, 2018
00fda3f
Fix AppImage VST
lukas-w Jun 11, 2018
4d5eb7f
CircleCI: Display Appimage log when failing
lukas-w Jun 11, 2018
0349b97
Fix AppImage 64bit RemoteVstPlugin libwine discovery
lukas-w Jun 11, 2018
af57300
VstPlugin: Fix define naming conflict with MinGW
lukas-w Jun 11, 2018
57fdaed
winegcc_wrapper: Remove misleading usage hint
lukas-w Jun 16, 2018
40a1e36
RemotePlugin: Revert unnecessary invalidate() changes
lukas-w Jun 24, 2018
642703e
Whitespace fix
lukas-w Jun 24, 2018
66c2047
CircleCI: Make sure build fails when AppImage building does
lukas-w Jun 25, 2018
65ccaff
RemoteVstPlugin: Fix confusing variable names
lukas-w Jun 25, 2018
d04965a
Merge branch 'master' into msvc/vst
lukas-w Jul 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
CircleCI: Display Appimage log when failing
  • Loading branch information
@lukas-w
lukas-w committed Jun 11, 2018
commit 4d5eb7f689dcb7a09b040ea52b7efedd80de791f
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ jobs:
command: |
cd build
make install
make appimage
make appimage || cat appimage.log
Copy link
Member

@tresf tresf Jun 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@PhysSong PhysSong Jun 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this mark the build as successful if AppImage creation is failed? I think it's fine if desired though.

Copy link
Member

@tresf tresf Jun 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps make appimage || cat appimage.log && false

Copy link
Member

@PhysSong PhysSong Jun 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps make appimage || cat appimage.log && false

I think there should be a pair of parenthesis: make appimage || (cat appimage.log && false)
See also: https://unix.stackexchange.com/questions/88850/

Copy link
Member

@tresf tresf Jun 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PhysSong tested, confirmed...

ls -al || (echo hello && false)
echo $?
# returns 0
ls -al || echo hello && false
echo $?
# returns 1

Copy link
Member Author

@lukas-w lukas-w Jun 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if appimage creation fails, it will fail one line later in cp ./lmms-*.AppImage /tmp/artifacts/. I'll still add the && false to make sure.

Copy link
Member

@PhysSong PhysSong Jun 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if appimage creation fails, it will fail one line later in cp ./lmms-*.AppImage /tmp/artifacts/.

True, I just missed that.

cp ./lmms-*.AppImage /tmp/artifacts/
- store_artifacts:
path: /tmp/artifacts/
Expand Down