LADSPA: Fix undefined reference due to vectorization #4434
Merged
+13
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4030 by always linking math library.
Recent version of GCC optimizes some math function calls by vectorization. It requires a library
mvec. GCC automatically links it if and only if math library is linked and target file needs the library.Since LMMS doesn't use vector math function, LMMS won't be linked against
mvec. It may cause crash on program loading and/or project loading.Additionally, this pull request drop useless
-Wl,-no-undefinedfor Windows(I guess it was needed bylibtool) and a flag which isn't used elsewhere, (-Wl,)-Bsymbolic.The MSVC check is for
master, but I've added it here because it can be missed when syncing branches.