Skip to content

Basic ghost notes feature. #4575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zonkmachine merged 9 commits into from Jan 17, 2019
Merged

Basic ghost notes feature. #4575

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f19e640
* Added basic ghost notes feature.
Sep 2, 2018
43459e5
* changed setGhostPattern parameter name from `newPattern` to `patter…
Sep 2, 2018
e103e76
* set ghost pattern `m_ghostPattern` to `nullptr` on `destroyedPatter…
Sep 3, 2018
a05223e
resized ghost note icon so it is aligned with the rest of the icons i…
Sep 3, 2018
2946905
Changed opacity variables data types back to `int` from `unsigned char`.
Sep 7, 2018
4e5493f
* Don’t show `Set as ghost in piano-roll` on empty pattern.
Jan 6, 2019
0da2a15
Disable `clear ghost notes` button in `Piano-Roll` when there is no g…
Jan 7, 2019
e455253
* Don’t clear ghost automaticly.
Jan 10, 2019
8681269
remove empty line.
Jan 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
* Don’t show Set as ghost in piano-roll on empty pattern. 
* Small change to comply more with the rest of the coding style.
  • Loading branch information
CYBERDEViLNL authored and CYBERDEViLNL committed Jan 6, 2019
commit 4e5493f23d738848a61622273d0ab53f8017fda6
9 changes: 7 additions & 2 deletions src/tracks/Pattern.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,14 +677,19 @@ void PatternView::constructContextMenu( QMenu * _cm )
connect( a, SIGNAL( triggered( bool ) ),
this, SLOT( openInPianoRoll() ) );

if( gui->pianoRoll()->currentPattern() && gui->pianoRoll()->currentPattern() != m_pat ){
if( gui->pianoRoll()->currentPattern() &&
gui->pianoRoll()->currentPattern() != m_pat &&
not m_pat->empty() )
{
QAction * b = new QAction( embed::getIconPixmap( "ghost_note" ),
tr( "Set as ghost in piano-roll" ), _cm );
_cm->insertAction( _cm->actions()[1], b );
connect( b, SIGNAL( triggered( bool ) ),
this, SLOT( setGhostInPianoRoll() ) );
_cm->insertSeparator( _cm->actions()[2] );
} else {
}
else
{
_cm->insertSeparator( _cm->actions()[1] );
}

Expand Down