Skip to content

Conversation

@jasp00
Copy link
Member

@jasp00 jasp00 commented Nov 4, 2018

This is the first step towards Debian integration, as stated in #4695.

@PhysSong
Copy link
Member

PhysSong commented Nov 4, 2018

Could you consider removing clang.patch? We don't add -Werror by default anymore. Also, I can't apply the old patch into current stable-1.2.
Also, CONTRIBUTORS are outdated in your patch.

@jasp00
Copy link
Member Author

jasp00 commented Nov 4, 2018

I did not explain that patches under debian/patches are not meant to be applied, since the package format is native.

Could you consider removing clang.patch?

It is only a reminder to add a clang pass on Debian sid.

We don't add -Werror by default anymore.

It is good practice to enable -Werror on sid. Specific errors can be disabled.

Also, CONTRIBUTORS are outdated in your patch.

It is just another reminder.

@trebmuh
Copy link
Contributor

trebmuh commented Nov 4, 2018

Suggestion to remove the debian/menu file following this Debian bug report which have deprecated the menu file.

@jasp00
Copy link
Member Author

jasp00 commented Nov 13, 2018

If there is no more feedback, I will merge this and continue the integration.

@jasp00 jasp00 merged commit ff06098 into stable-1.2 Nov 14, 2018
@jasp00 jasp00 deleted the debian-pkg branch November 14, 2018 13:01
@PhysSong
Copy link
Member

I forgot to mention that debian/lmms.xpm should be updated according to #4519.

@jasp00 jasp00 mentioned this pull request Nov 15, 2018
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
* Add initial Debian packaging for stable-1.2

* Drop Debian menu entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants